 7eb187b3cd
			
		
	
	
	7eb187b3cd
	
	
	
		
			
			The dw_{read,write}[lw] macros produce sparse warnings everytime they
are used.  The "read" ones cause:
warning: cast removes address space of expression
warning: incorrect type in argument 1 (different address spaces)
   expected void const volatile [noderef] <asn:2>*addr
   got unsigned int *<noident>
And the "write" ones:
warning: cast removes address space of expression
warning: incorrect type in argument 2 (different address spaces)
   expected void volatile [noderef] <asn:2>*addr
   got unsigned int *<noident>
Fix this by removing struct dw_spi_reg and converting all the register
offsets to #defines. Then convert the macros into inlined functions so
that proper type checking can occur.
While here, also fix the three sparse warnings in spi-dw-mid.c due to
the return value of ioremap_nocache being stored in a u32 * not a
void __iomem *.
With these changes the spi-dw* files all build with no sparse warnings.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Acked-by: Feng Tang <feng.tang@intel.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
		
	
			
		
			
				
	
	
		
			242 lines
		
	
	
	
		
			5.8 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			242 lines
		
	
	
	
		
			5.8 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
| #ifndef DW_SPI_HEADER_H
 | |
| #define DW_SPI_HEADER_H
 | |
| 
 | |
| #include <linux/io.h>
 | |
| #include <linux/scatterlist.h>
 | |
| 
 | |
| /* Register offsets */
 | |
| #define DW_SPI_CTRL0			0x00
 | |
| #define DW_SPI_CTRL1			0x04
 | |
| #define DW_SPI_SSIENR			0x08
 | |
| #define DW_SPI_MWCR			0x0c
 | |
| #define DW_SPI_SER			0x10
 | |
| #define DW_SPI_BAUDR			0x14
 | |
| #define DW_SPI_TXFLTR			0x18
 | |
| #define DW_SPI_RXFLTR			0x1c
 | |
| #define DW_SPI_TXFLR			0x20
 | |
| #define DW_SPI_RXFLR			0x24
 | |
| #define DW_SPI_SR			0x28
 | |
| #define DW_SPI_IMR			0x2c
 | |
| #define DW_SPI_ISR			0x30
 | |
| #define DW_SPI_RISR			0x34
 | |
| #define DW_SPI_TXOICR			0x38
 | |
| #define DW_SPI_RXOICR			0x3c
 | |
| #define DW_SPI_RXUICR			0x40
 | |
| #define DW_SPI_MSTICR			0x44
 | |
| #define DW_SPI_ICR			0x48
 | |
| #define DW_SPI_DMACR			0x4c
 | |
| #define DW_SPI_DMATDLR			0x50
 | |
| #define DW_SPI_DMARDLR			0x54
 | |
| #define DW_SPI_IDR			0x58
 | |
| #define DW_SPI_VERSION			0x5c
 | |
| #define DW_SPI_DR			0x60
 | |
| 
 | |
| /* Bit fields in CTRLR0 */
 | |
| #define SPI_DFS_OFFSET			0
 | |
| 
 | |
| #define SPI_FRF_OFFSET			4
 | |
| #define SPI_FRF_SPI			0x0
 | |
| #define SPI_FRF_SSP			0x1
 | |
| #define SPI_FRF_MICROWIRE		0x2
 | |
| #define SPI_FRF_RESV			0x3
 | |
| 
 | |
| #define SPI_MODE_OFFSET			6
 | |
| #define SPI_SCPH_OFFSET			6
 | |
| #define SPI_SCOL_OFFSET			7
 | |
| 
 | |
| #define SPI_TMOD_OFFSET			8
 | |
| #define SPI_TMOD_MASK			(0x3 << SPI_TMOD_OFFSET)
 | |
| #define	SPI_TMOD_TR			0x0		/* xmit & recv */
 | |
| #define SPI_TMOD_TO			0x1		/* xmit only */
 | |
| #define SPI_TMOD_RO			0x2		/* recv only */
 | |
| #define SPI_TMOD_EPROMREAD		0x3		/* eeprom read mode */
 | |
| 
 | |
| #define SPI_SLVOE_OFFSET		10
 | |
| #define SPI_SRL_OFFSET			11
 | |
| #define SPI_CFS_OFFSET			12
 | |
| 
 | |
| /* Bit fields in SR, 7 bits */
 | |
| #define SR_MASK				0x7f		/* cover 7 bits */
 | |
| #define SR_BUSY				(1 << 0)
 | |
| #define SR_TF_NOT_FULL			(1 << 1)
 | |
| #define SR_TF_EMPT			(1 << 2)
 | |
| #define SR_RF_NOT_EMPT			(1 << 3)
 | |
| #define SR_RF_FULL			(1 << 4)
 | |
| #define SR_TX_ERR			(1 << 5)
 | |
| #define SR_DCOL				(1 << 6)
 | |
| 
 | |
| /* Bit fields in ISR, IMR, RISR, 7 bits */
 | |
| #define SPI_INT_TXEI			(1 << 0)
 | |
| #define SPI_INT_TXOI			(1 << 1)
 | |
| #define SPI_INT_RXUI			(1 << 2)
 | |
| #define SPI_INT_RXOI			(1 << 3)
 | |
| #define SPI_INT_RXFI			(1 << 4)
 | |
| #define SPI_INT_MSTI			(1 << 5)
 | |
| 
 | |
| /* TX RX interrupt level threshold, max can be 256 */
 | |
| #define SPI_INT_THRESHOLD		32
 | |
| 
 | |
| enum dw_ssi_type {
 | |
| 	SSI_MOTO_SPI = 0,
 | |
| 	SSI_TI_SSP,
 | |
| 	SSI_NS_MICROWIRE,
 | |
| };
 | |
| 
 | |
| struct dw_spi;
 | |
| struct dw_spi_dma_ops {
 | |
| 	int (*dma_init)(struct dw_spi *dws);
 | |
| 	void (*dma_exit)(struct dw_spi *dws);
 | |
| 	int (*dma_transfer)(struct dw_spi *dws, int cs_change);
 | |
| };
 | |
| 
 | |
| struct dw_spi {
 | |
| 	struct spi_master	*master;
 | |
| 	struct spi_device	*cur_dev;
 | |
| 	struct device		*parent_dev;
 | |
| 	enum dw_ssi_type	type;
 | |
| 	char			name[16];
 | |
| 
 | |
| 	void __iomem		*regs;
 | |
| 	unsigned long		paddr;
 | |
| 	u32			iolen;
 | |
| 	int			irq;
 | |
| 	u32			fifo_len;	/* depth of the FIFO buffer */
 | |
| 	u32			max_freq;	/* max bus freq supported */
 | |
| 
 | |
| 	u16			bus_num;
 | |
| 	u16			num_cs;		/* supported slave numbers */
 | |
| 
 | |
| 	/* Driver message queue */
 | |
| 	struct workqueue_struct	*workqueue;
 | |
| 	struct work_struct	pump_messages;
 | |
| 	spinlock_t		lock;
 | |
| 	struct list_head	queue;
 | |
| 	int			busy;
 | |
| 	int			run;
 | |
| 
 | |
| 	/* Message Transfer pump */
 | |
| 	struct tasklet_struct	pump_transfers;
 | |
| 
 | |
| 	/* Current message transfer state info */
 | |
| 	struct spi_message	*cur_msg;
 | |
| 	struct spi_transfer	*cur_transfer;
 | |
| 	struct chip_data	*cur_chip;
 | |
| 	struct chip_data	*prev_chip;
 | |
| 	size_t			len;
 | |
| 	void			*tx;
 | |
| 	void			*tx_end;
 | |
| 	void			*rx;
 | |
| 	void			*rx_end;
 | |
| 	int			dma_mapped;
 | |
| 	dma_addr_t		rx_dma;
 | |
| 	dma_addr_t		tx_dma;
 | |
| 	size_t			rx_map_len;
 | |
| 	size_t			tx_map_len;
 | |
| 	u8			n_bytes;	/* current is a 1/2 bytes op */
 | |
| 	u8			max_bits_per_word;	/* maxim is 16b */
 | |
| 	u32			dma_width;
 | |
| 	int			cs_change;
 | |
| 	irqreturn_t		(*transfer_handler)(struct dw_spi *dws);
 | |
| 	void			(*cs_control)(u32 command);
 | |
| 
 | |
| 	/* Dma info */
 | |
| 	int			dma_inited;
 | |
| 	struct dma_chan		*txchan;
 | |
| 	struct scatterlist	tx_sgl;
 | |
| 	struct dma_chan		*rxchan;
 | |
| 	struct scatterlist	rx_sgl;
 | |
| 	int			dma_chan_done;
 | |
| 	struct device		*dma_dev;
 | |
| 	dma_addr_t		dma_addr; /* phy address of the Data register */
 | |
| 	struct dw_spi_dma_ops	*dma_ops;
 | |
| 	void			*dma_priv; /* platform relate info */
 | |
| 	struct pci_dev		*dmac;
 | |
| 
 | |
| 	/* Bus interface info */
 | |
| 	void			*priv;
 | |
| #ifdef CONFIG_DEBUG_FS
 | |
| 	struct dentry *debugfs;
 | |
| #endif
 | |
| };
 | |
| 
 | |
| static inline u32 dw_readl(struct dw_spi *dws, u32 offset)
 | |
| {
 | |
| 	return __raw_readl(dws->regs + offset);
 | |
| }
 | |
| 
 | |
| static inline void dw_writel(struct dw_spi *dws, u32 offset, u32 val)
 | |
| {
 | |
| 	__raw_writel(val, dws->regs + offset);
 | |
| }
 | |
| 
 | |
| static inline u16 dw_readw(struct dw_spi *dws, u32 offset)
 | |
| {
 | |
| 	return __raw_readw(dws->regs + offset);
 | |
| }
 | |
| 
 | |
| static inline void dw_writew(struct dw_spi *dws, u32 offset, u16 val)
 | |
| {
 | |
| 	__raw_writew(val, dws->regs + offset);
 | |
| }
 | |
| 
 | |
| static inline void spi_enable_chip(struct dw_spi *dws, int enable)
 | |
| {
 | |
| 	dw_writel(dws, DW_SPI_SSIENR, (enable ? 1 : 0));
 | |
| }
 | |
| 
 | |
| static inline void spi_set_clk(struct dw_spi *dws, u16 div)
 | |
| {
 | |
| 	dw_writel(dws, DW_SPI_BAUDR, div);
 | |
| }
 | |
| 
 | |
| static inline void spi_chip_sel(struct dw_spi *dws, u16 cs)
 | |
| {
 | |
| 	if (cs > dws->num_cs)
 | |
| 		return;
 | |
| 
 | |
| 	if (dws->cs_control)
 | |
| 		dws->cs_control(1);
 | |
| 
 | |
| 	dw_writel(dws, DW_SPI_SER, 1 << cs);
 | |
| }
 | |
| 
 | |
| /* Disable IRQ bits */
 | |
| static inline void spi_mask_intr(struct dw_spi *dws, u32 mask)
 | |
| {
 | |
| 	u32 new_mask;
 | |
| 
 | |
| 	new_mask = dw_readl(dws, DW_SPI_IMR) & ~mask;
 | |
| 	dw_writel(dws, DW_SPI_IMR, new_mask);
 | |
| }
 | |
| 
 | |
| /* Enable IRQ bits */
 | |
| static inline void spi_umask_intr(struct dw_spi *dws, u32 mask)
 | |
| {
 | |
| 	u32 new_mask;
 | |
| 
 | |
| 	new_mask = dw_readl(dws, DW_SPI_IMR) | mask;
 | |
| 	dw_writel(dws, DW_SPI_IMR, new_mask);
 | |
| }
 | |
| 
 | |
| /*
 | |
|  * Each SPI slave device to work with dw_api controller should
 | |
|  * has such a structure claiming its working mode (PIO/DMA etc),
 | |
|  * which can be save in the "controller_data" member of the
 | |
|  * struct spi_device
 | |
|  */
 | |
| struct dw_spi_chip {
 | |
| 	u8 poll_mode;	/* 0 for contoller polling mode */
 | |
| 	u8 type;	/* SPI/SSP/Micrwire */
 | |
| 	u8 enable_dma;
 | |
| 	void (*cs_control)(u32 command);
 | |
| };
 | |
| 
 | |
| extern int dw_spi_add_host(struct dw_spi *dws);
 | |
| extern void dw_spi_remove_host(struct dw_spi *dws);
 | |
| extern int dw_spi_suspend_host(struct dw_spi *dws);
 | |
| extern int dw_spi_resume_host(struct dw_spi *dws);
 | |
| extern void dw_spi_xfer_done(struct dw_spi *dws);
 | |
| 
 | |
| /* platform related setup */
 | |
| extern int dw_spi_mid_init(struct dw_spi *dws); /* Intel MID platforms */
 | |
| #endif /* DW_SPI_HEADER_H */
 |