 f96637be08
			
		
	
	
	f96637be08
	
	
	
		
			
			It's not obvious from reading the macro names that these macros are for debugging. Convert the names to a single more typical kernel style cifs_dbg macro. cERROR(1, ...) -> cifs_dbg(VFS, ...) cFYI(1, ...) -> cifs_dbg(FYI, ...) cFYI(DBG2, ...) -> cifs_dbg(NOISY, ...) Move the terminating format newline from the macro to the call site. Add CONFIG_CIFS_DEBUG function cifs_vfs_err to emit the "CIFS VFS: " prefix for VFS messages. Size is reduced ~ 1% when CONFIG_CIFS_DEBUG is set (default y) $ size fs/cifs/cifs.ko* text data bss dec hex filename 265245 2525 132 267902 4167e fs/cifs/cifs.ko.new 268359 2525 132 271016 422a8 fs/cifs/cifs.ko.old Other miscellaneous changes around these conversions: o Miscellaneous typo fixes o Add terminating \n's to almost all formats and remove them from the macros to be more kernel style like. A few formats previously had defective \n's o Remove unnecessary OOM messages as kmalloc() calls dump_stack o Coalesce formats to make grep easier, added missing spaces when coalescing formats o Use %s, __func__ instead of embedded function name o Removed unnecessary "cifs: " prefixes o Convert kzalloc with multiply to kcalloc o Remove unused cifswarn macro Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Steve French <smfrench@gmail.com>
		
			
				
	
	
		
			96 lines
		
	
	
	
		
			2.7 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			96 lines
		
	
	
	
		
			2.7 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
| /*
 | |
|  *   fs/cifs/ioctl.c
 | |
|  *
 | |
|  *   vfs operations that deal with io control
 | |
|  *
 | |
|  *   Copyright (C) International Business Machines  Corp., 2005,2007
 | |
|  *   Author(s): Steve French (sfrench@us.ibm.com)
 | |
|  *
 | |
|  *   This library is free software; you can redistribute it and/or modify
 | |
|  *   it under the terms of the GNU Lesser General Public License as published
 | |
|  *   by the Free Software Foundation; either version 2.1 of the License, or
 | |
|  *   (at your option) any later version.
 | |
|  *
 | |
|  *   This library is distributed in the hope that it will be useful,
 | |
|  *   but WITHOUT ANY WARRANTY; without even the implied warranty of
 | |
|  *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See
 | |
|  *   the GNU Lesser General Public License for more details.
 | |
|  *
 | |
|  *   You should have received a copy of the GNU Lesser General Public License
 | |
|  *   along with this library; if not, write to the Free Software
 | |
|  *   Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
 | |
|  */
 | |
| 
 | |
| #include <linux/fs.h>
 | |
| #include "cifspdu.h"
 | |
| #include "cifsglob.h"
 | |
| #include "cifsproto.h"
 | |
| #include "cifs_debug.h"
 | |
| #include "cifsfs.h"
 | |
| 
 | |
| long cifs_ioctl(struct file *filep, unsigned int command, unsigned long arg)
 | |
| {
 | |
| 	struct inode *inode = file_inode(filep);
 | |
| 	int rc = -ENOTTY; /* strange error - but the precedent */
 | |
| 	unsigned int xid;
 | |
| 	struct cifs_sb_info *cifs_sb;
 | |
| #ifdef CONFIG_CIFS_POSIX
 | |
| 	struct cifsFileInfo *pSMBFile = filep->private_data;
 | |
| 	struct cifs_tcon *tcon;
 | |
| 	__u64	ExtAttrBits = 0;
 | |
| 	__u64	ExtAttrMask = 0;
 | |
| 	__u64   caps;
 | |
| #endif /* CONFIG_CIFS_POSIX */
 | |
| 
 | |
| 	xid = get_xid();
 | |
| 
 | |
| 	cifs_dbg(FYI, "ioctl file %p  cmd %u  arg %lu\n", filep, command, arg);
 | |
| 
 | |
| 	cifs_sb = CIFS_SB(inode->i_sb);
 | |
| 
 | |
| 	switch (command) {
 | |
| #ifdef CONFIG_CIFS_POSIX
 | |
| 		case FS_IOC_GETFLAGS:
 | |
| 			if (pSMBFile == NULL)
 | |
| 				break;
 | |
| 			tcon = tlink_tcon(pSMBFile->tlink);
 | |
| 			caps = le64_to_cpu(tcon->fsUnixInfo.Capability);
 | |
| 			if (CIFS_UNIX_EXTATTR_CAP & caps) {
 | |
| 				rc = CIFSGetExtAttr(xid, tcon,
 | |
| 						    pSMBFile->fid.netfid,
 | |
| 						    &ExtAttrBits, &ExtAttrMask);
 | |
| 				if (rc == 0)
 | |
| 					rc = put_user(ExtAttrBits &
 | |
| 						FS_FL_USER_VISIBLE,
 | |
| 						(int __user *)arg);
 | |
| 			}
 | |
| 			break;
 | |
| 
 | |
| 		case FS_IOC_SETFLAGS:
 | |
| 			if (pSMBFile == NULL)
 | |
| 				break;
 | |
| 			tcon = tlink_tcon(pSMBFile->tlink);
 | |
| 			caps = le64_to_cpu(tcon->fsUnixInfo.Capability);
 | |
| 			if (CIFS_UNIX_EXTATTR_CAP & caps) {
 | |
| 				if (get_user(ExtAttrBits, (int __user *)arg)) {
 | |
| 					rc = -EFAULT;
 | |
| 					break;
 | |
| 				}
 | |
| 				/*
 | |
| 				 * rc = CIFSGetExtAttr(xid, tcon,
 | |
| 				 *		       pSMBFile->fid.netfid,
 | |
| 				 *		       extAttrBits,
 | |
| 				 *		       &ExtAttrMask);
 | |
| 				 */
 | |
| 			}
 | |
| 			cifs_dbg(FYI, "set flags not implemented yet\n");
 | |
| 			break;
 | |
| #endif /* CONFIG_CIFS_POSIX */
 | |
| 		default:
 | |
| 			cifs_dbg(FYI, "unsupported ioctl\n");
 | |
| 			break;
 | |
| 	}
 | |
| 
 | |
| 	free_xid(xid);
 | |
| 	return rc;
 | |
| }
 |