forge/linux-pinenote
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

backlight: lp855x: remove duplicate platform data

Browse source 
The 'load_new_rom_data' was used for checking whether new ROM data should
be updated or not.

However, we can decide it with 'size_program' data.  If the size is
greater than 0, it means updating ROM area is required.  Otherwise, the
default ROM data will be used.  Therefore, this duplicate platform data
can be removed.

Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Kim, Milo 2013-04-29 16:18:05 -07:00 • committed by Linus Torvalds
commit c365e59d47
3 changed files with 1 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Documentation/backlight/lp855x-driver.txt
View file

@ -36,9 +36,6 @@ For supporting platform specific data, the lp855x platform data can be used.
* initial_brightness : Initial value of backlight brightness. * initial_brightness : Initial value of backlight brightness.
* period_ns : Platform specific PWM period value. unit is nano. * period_ns : Platform specific PWM period value. unit is nano.
Only valid when brightness is pwm input mode. Only valid when brightness is pwm input mode.
* load_new_rom_data :
0 : use default configuration data
1 : update values of eeprom or eprom registers on loading driver
* size_program : Total size of lp855x_rom_data. * size_program : Total size of lp855x_rom_data.
* rom_data : List of new eeprom/eprom registers. * rom_data : List of new eeprom/eprom registers.
@ -55,7 +52,6 @@ static struct lp855x_platform_data lp8552_pdata = {
.name = "lcd-bl", .name = "lcd-bl",
.device_control = I2C_CONFIG(LP8552), .device_control = I2C_CONFIG(LP8552),
.initial_brightness = INITIAL_BRT, .initial_brightness = INITIAL_BRT,
.load_new_rom_data = 1,
.size_program = ARRAY_SIZE(lp8552_eeprom_arr), .size_program = ARRAY_SIZE(lp8552_eeprom_arr),
.rom_data = lp8552_eeprom_arr, .rom_data = lp8552_eeprom_arr,
}; };

2
drivers/video/backlight/lp855x_bl.c
View file

@ -192,7 +192,7 @@ static int lp855x_configure(struct lp855x *lp)
if (ret) if (ret)
goto err; goto err;
if (pd->load_new_rom_data && pd->size_program) { if (pd->size_program > 0) {
for (i = 0; i < pd->size_program; i++) { for (i = 0; i < pd->size_program; i++) {
addr = pd->rom_data[i].addr; addr = pd->rom_data[i].addr;
val = pd->rom_data[i].val; val = pd->rom_data[i].val;

4
include/linux/platform_data/lp855x.h
View file

@ -115,9 +115,6 @@ struct lp855x_rom_data {
* @initial_brightness : initial value of backlight brightness * @initial_brightness : initial value of backlight brightness
* @period_ns : platform specific pwm period value. unit is nano. * @period_ns : platform specific pwm period value. unit is nano.
Only valid when mode is PWM_BASED. Only valid when mode is PWM_BASED.
* @load_new_rom_data :
0 : use default configuration data
1 : update values of eeprom or eprom registers on loading driver
* @size_program : total size of lp855x_rom_data * @size_program : total size of lp855x_rom_data
* @rom_data : list of new eeprom/eprom registers * @rom_data : list of new eeprom/eprom registers
*/ */
@ -126,7 +123,6 @@ struct lp855x_platform_data {
u8 device_control; u8 device_control;
u8 initial_brightness; u8 initial_brightness;
unsigned int period_ns; unsigned int period_ns;
u8 load_new_rom_data;
int size_program; int size_program;
struct lp855x_rom_data *rom_data; struct lp855x_rom_data *rom_data;
}; };