forge/linux-pinenote
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mmc: sdhci: Fix incorrect ADMA2 descriptor table size

Browse source 
The ADMA2 descriptor table size was being calculated incorrectly
Fix it.

Note that it has been wrong for a long time and likely has not
caused any problems because of a combination of 1) not needing
alignment descriptors for block operations 2) more memory being
allocated than was requested 3) the use of
SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC which does not use an extra
descriptor for the end marker.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
This commit is contained in:
Adrian Hunter 2014-11-04 12:42:35 +02:00 • committed by Ulf Hansson
commit c09df940eb
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
drivers/mmc/host/sdhci.c
View file

@ -44,7 +44,13 @@
#define MAX_TUNING_LOOP 40 #define MAX_TUNING_LOOP 40
#define ADMA_SIZE ((128 * 2 + 1) * 4) /*
* The ADMA2 descriptor table size is calculated as the maximum number of
* segments (128), times 2 to allow for an alignment descriptor for each
* segment, plus 1 for a nop end descriptor, all multipled by the 32-bit
* descriptor size (8).
*/
#define ADMA_SIZE ((128 * 2 + 1) * 8)
static unsigned int debug_quirks = 0; static unsigned int debug_quirks = 0;
static unsigned int debug_quirks2; static unsigned int debug_quirks2;