forge/linux-pinenote
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

LSM: remove the task field from common_audit_data

Browse source 
There are no legitimate users.  Always use current and get back some stack
space for the common_audit_data.

Signed-off-by: Eric Paris <eparis@redhat.com>
This commit is contained in:
Eric Paris 2012-04-04 15:01:43 -04:00
parent 0972c74ecb
commit b466066f9b
3 changed files with 2 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

1
include/linux/lsm_audit.h
View file

@ -53,7 +53,6 @@ struct common_audit_data {
#define LSM_AUDIT_DATA_KMOD 8 #define LSM_AUDIT_DATA_KMOD 8
#define LSM_AUDIT_DATA_INODE 9 #define LSM_AUDIT_DATA_INODE 9
#define LSM_AUDIT_DATA_DENTRY 10 #define LSM_AUDIT_DATA_DENTRY 10
struct task_struct *tsk;
union { union {
struct path path; struct path path;
struct dentry *dentry; struct dentry *dentry;

8
security/lsm_audit.c
View file

@ -213,12 +213,8 @@ static void dump_common_audit_data(struct audit_buffer *ab,
{ {
struct task_struct *tsk = current; struct task_struct *tsk = current;
if (a->tsk) audit_log_format(ab, " pid=%d comm=", tsk->pid);
tsk = a->tsk; audit_log_untrustedstring(ab, tsk->comm);
if (tsk && tsk->pid) {
audit_log_format(ab, " pid=%d comm=", tsk->pid);
audit_log_untrustedstring(ab, tsk->comm);
}
switch (a->type) { switch (a->type) {
case LSM_AUDIT_DATA_NONE: case LSM_AUDIT_DATA_NONE:

1
security/selinux/hooks.c
View file

@ -1429,7 +1429,6 @@ static int cred_has_capability(const struct cred *cred,
COMMON_AUDIT_DATA_INIT(&ad, LSM_AUDIT_DATA_CAP); COMMON_AUDIT_DATA_INIT(&ad, LSM_AUDIT_DATA_CAP);
ad.selinux_audit_data = &sad; ad.selinux_audit_data = &sad;
ad.tsk = current;
ad.u.cap = cap; ad.u.cap = cap;
switch (CAP_TO_INDEX(cap)) { switch (CAP_TO_INDEX(cap)) {