forge/linux-pinenote
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ALSA: sound/pci/rme9652/hdspm.c: fix error return code

Browse source 
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}

// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Julia Lawall 2012-08-19 09:02:54 +02:00 • committed by Takashi Iwai
parent ae970eb45d
commit b17cbdd85f
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
sound/pci/rme9652/hdspm.c
View file

@ -6585,7 +6585,7 @@ static int __devinit snd_hdspm_create(struct snd_card *card,
snd_printk(KERN_ERR "HDSPM: " snd_printk(KERN_ERR "HDSPM: "
"unable to kmalloc Mixer memory of %d Bytes\n", "unable to kmalloc Mixer memory of %d Bytes\n",
(int)sizeof(struct hdspm_mixer)); (int)sizeof(struct hdspm_mixer));
return err; return -ENOMEM;
} }
hdspm->port_names_in = NULL; hdspm->port_names_in = NULL;