forge/linux-pinenote
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ALSA: aoa: Delete an unnecessary check before the function call "snd_pcm_suspend_all"

Browse source 
The snd_pcm_suspend_all() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Markus Elfring 2015-01-03 20:43:01 +01:00 • committed by Takashi Iwai
commit aa57b93b27
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
sound/aoa/soundbus/i2sbus/core.c
View file

@ -381,10 +381,8 @@ static int i2sbus_suspend(struct macio_dev* dev, pm_message_t state)
list_for_each_entry(i2sdev, &control->list, item) { list_for_each_entry(i2sdev, &control->list, item) {
/* Notify Alsa */ /* Notify Alsa */
if (i2sdev->sound.pcm) { /* Suspend PCM streams */
/* Suspend PCM streams */ snd_pcm_suspend_all(i2sdev->sound.pcm);
snd_pcm_suspend_all(i2sdev->sound.pcm);
}
/* Notify codecs */ /* Notify codecs */
list_for_each_entry(cii, &i2sdev->sound.codec_list, list) { list_for_each_entry(cii, &i2sdev->sound.codec_list, list) {