forge/linux-pinenote
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

irda: replace current->state by set_current_state()

Browse source 
Use helper functions to access current->state.
Direct assignments are prone to races and therefore buggy.

current->state = TASK_RUNNING can be replaced by __set_current_state()

Thanks to Peter Zijlstra for the exact definition of the problem.

Suggested-By: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Fabian Frederick 2015-02-23 18:38:24 +01:00 • committed by David S. Miller
commit a948f8ce77
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
net/irda/ircomm/ircomm_tty.c
View file

@ -811,7 +811,7 @@ static void ircomm_tty_wait_until_sent(struct tty_struct *tty, int timeout)
break; break;
} }
spin_unlock_irqrestore(&self->spinlock, flags); spin_unlock_irqrestore(&self->spinlock, flags);
current->state = TASK_RUNNING; __set_current_state(TASK_RUNNING);
} }
/* /*

4
net/irda/irnet/irnet_ppp.c
View file

@ -305,7 +305,7 @@ irnet_ctrl_read(irnet_socket * ap,
/* Put ourselves on the wait queue to be woken up */ /* Put ourselves on the wait queue to be woken up */
add_wait_queue(&irnet_events.rwait, &wait); add_wait_queue(&irnet_events.rwait, &wait);
current->state = TASK_INTERRUPTIBLE; set_current_state(TASK_INTERRUPTIBLE);
for(;;) for(;;)
{ {
/* If there is unread events */ /* If there is unread events */
@ -321,7 +321,7 @@ irnet_ctrl_read(irnet_socket * ap,
/* Yield and wait to be woken up */ /* Yield and wait to be woken up */
schedule(); schedule();
} }
current->state = TASK_RUNNING; __set_current_state(TASK_RUNNING);
remove_wait_queue(&irnet_events.rwait, &wait); remove_wait_queue(&irnet_events.rwait, &wait);
/* Did we got it ? */ /* Did we got it ? */