forge/linux-pinenote
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

bridge: use list_for_each_entry_continue_reverse

Browse source 
use list_for_each_entry_continue_reverse to rollback in fdb_add_hw
when add address failed

Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Li RongQing 2014-06-18 16:07:16 +08:00 • committed by David S. Miller
commit a3f5ee71cd
1 changed files with 4 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
net/bridge/br_fdb.c
View file

@ -93,7 +93,7 @@ static void fdb_rcu_free(struct rcu_head *head)
static void fdb_add_hw(struct net_bridge *br, const unsigned char *addr) static void fdb_add_hw(struct net_bridge *br, const unsigned char *addr)
{ {
int err; int err;
struct net_bridge_port *p, *tmp; struct net_bridge_port *p;
ASSERT_RTNL(); ASSERT_RTNL();
@ -107,11 +107,9 @@ static void fdb_add_hw(struct net_bridge *br, const unsigned char *addr)
return; return;
undo: undo:
list_for_each_entry(tmp, &br->port_list, list) { list_for_each_entry_continue_reverse(p, &br->port_list, list) {
if (tmp == p) if (!br_promisc_port(p))
break; dev_uc_del(p->dev, addr);
if (!br_promisc_port(tmp))
dev_uc_del(tmp->dev, addr);
} }
} }