forge/linux-pinenote
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

regulator: core: Prevent integer underflow

Browse source 
By using a ratio of delay to poll_enabled_time that is not integer
time_remaining underflows and does not exit the loop as expected.
As delay could be derived from DT and poll_enabled_time is defined
in the driver this can easily happen.

Use a signed iterator to make sure that the loop exits once
the remaining time is negative.

Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Link: https://lore.kernel.org/r/20220909125954.577669-1-patrick.rudolph@9elements.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Patrick Rudolph 2022-09-09 14:59:53 +02:00 • committed by Mark Brown
parent 08865c2150
commit 8d8e165920
No known key found for this signature in database
GPG key ID: 24D68B725D5487D0
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
drivers/regulator/core.c
View file

@ -2699,7 +2699,7 @@ static int _regulator_do_enable(struct regulator_dev *rdev)
* return -ETIMEDOUT. * return -ETIMEDOUT.
*/ */
if (rdev->desc->poll_enabled_time) { if (rdev->desc->poll_enabled_time) {
unsigned int time_remaining = delay; int time_remaining = delay;
while (time_remaining > 0) { while (time_remaining > 0) {
_regulator_delay_helper(rdev->desc->poll_enabled_time); _regulator_delay_helper(rdev->desc->poll_enabled_time);