forge/linux-pinenote
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

usbnet: smsc95xx: dereferencing NULL pointer

Browse source 
we were dereferencing dev to initialize pdata. but just after that we
have a BUG_ON(!dev). so we were basically dereferencing the pointer
first and then tesing it for NULL.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Sudip Mukherjee 2014-11-11 14:10:47 +05:30 • committed by David S. Miller
commit 8bca81d987
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
drivers/net/usb/smsc95xx.c
View file

@ -1670,12 +1670,14 @@ done:
static int smsc95xx_resume(struct usb_interface *intf)
{
struct usbnet *dev = usb_get_intfdata(intf);
struct smsc95xx_priv *pdata = (struct smsc95xx_priv *)(dev->data[0]);
u8 suspend_flags = pdata->suspend_flags;
struct smsc95xx_priv *pdata;
u8 suspend_flags;
int ret;
u32 val;
BUG_ON(!dev);
pdata = (struct smsc95xx_priv *)(dev->data[0]);
suspend_flags = pdata->suspend_flags;
netdev_dbg(dev->net, "resume suspend_flags=0x%02x\n", suspend_flags);