forge/linux-pinenote
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

net: sched: remove tcf_proto from ematch calls

Browse source 
This removes the tcf_proto argument from the ematch code paths that
only need it to reference the net namespace. This allows simplifying
qdisc code paths especially when we need to tear down the ematch
from an RCU callback. In this case we can not guarentee that the
tcf_proto structure is still valid.

Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Acked-by: Cong Wang <cwang@twopensource.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
John Fastabend 2014-10-05 21:27:53 -07:00 • committed by David S. Miller
parent fcbeb976d7
commit 82a470f111
10 changed files with 26 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

4
net/sched/cls_cgroup.c
View file

@ -87,7 +87,7 @@ static void cls_cgroup_destroy_rcu(struct rcu_head *root)
rcu);
tcf_exts_destroy(&head->exts);
tcf_em_tree_destroy(head->tp, &head->ematches);
tcf_em_tree_destroy(&head->ematches);
kfree(head);
}
@ -157,7 +157,7 @@ static void cls_cgroup_destroy(struct tcf_proto *tp)
if (head) {
tcf_exts_destroy(&head->exts);
tcf_em_tree_destroy(tp, &head->ematches);
tcf_em_tree_destroy(&head->ematches);
RCU_INIT_POINTER(tp->root, NULL);
kfree_rcu(head, rcu);
}