forge/linux-pinenote
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ip_frag: dont touch device refcount

Browse source 
When sending fragmentation expiration ICMP V4/V6 messages,
we can avoid touching device refcount, thanks to RCU

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Eric Dumazet 2009-11-05 20:59:47 -08:00 • committed by David S. Miller
parent bd27a8750c
commit 69df9d5993
2 changed files with 11 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

7
net/ipv4/ip_fragment.c
View file

@ -206,10 +206,11 @@ static void ip_expire(unsigned long arg)
struct sk_buff *head = qp->q.fragments;
/* Send an ICMP "Fragment Reassembly Timeout" message. */
if ((head->dev = dev_get_by_index(net, qp->iif)) != NULL) {
rcu_read_lock();
head->dev = dev_get_by_index_rcu(net, qp->iif);
if (head->dev)
icmp_send(head, ICMP_TIME_EXCEEDED, ICMP_EXC_FRAGTIME, 0);
dev_put(head->dev);
}
rcu_read_unlock();
}
out:
spin_unlock(&qp->q.lock);