forge/linux-pinenote
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[media] uvcvideo: Fix control value clamping for unsigned integer controls

Browse source 
V4L2 integer controls are stored in signed 32-bit values. However, UVC
controls can be either signed or unsigned. Take the UVC control
signedness into account when clamping the control value to the min-max
range.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Laurent Pinchart 2012-09-26 08:15:24 -03:00 • committed by Mauro Carvalho Chehab
commit 64ae9958a6
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
drivers/media/usb/uvc/uvc_ctrl.c
View file

@ -1455,8 +1455,12 @@ int uvc_ctrl_set(struct uvc_video_chain *chain,
if (step == 0) if (step == 0)
step = 1; step = 1;
xctrl->value = min + (xctrl->value - min + step/2) / step * step; xctrl->value = min + ((u32)(xctrl->value - min) + step / 2)
/ step * step;
if (mapping->data_type == UVC_CTRL_DATA_TYPE_SIGNED)
xctrl->value = clamp(xctrl->value, min, max); xctrl->value = clamp(xctrl->value, min, max);
else
xctrl->value = clamp_t(u32, xctrl->value, min, max);
value = xctrl->value; value = xctrl->value;
break; break;