drivers/net/pcmcia: Use pr_<level> and netdev_<level>
On Mon, 2010-08-09 at 17:34 +0200, Dominik Brodowski wrote: > look good from a PCMCIA point of view, therefore: > Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net> If PCMCIA is still being looked after, then here's another for you, maybe for 2.6.37. Use the more descriptive logging message styles. There are whitespace/indentation errors in the original sources that these changes do not modify, so checkpatch errors were cheerfully ignored. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
00093fab98
commit
636b8116d4
9 changed files with 298 additions and 314 deletions
|
@ -52,23 +52,23 @@
|
|||
|
||||
#define VERSION "arcnet: COM20020 PCMCIA support loaded.\n"
|
||||
|
||||
#ifdef DEBUG
|
||||
|
||||
static void regdump(struct net_device *dev)
|
||||
{
|
||||
#ifdef DEBUG
|
||||
int ioaddr = dev->base_addr;
|
||||
int count;
|
||||
|
||||
printk("com20020 register dump:\n");
|
||||
netdev_dbg(dev, "register dump:\n");
|
||||
for (count = ioaddr; count < ioaddr + 16; count++)
|
||||
{
|
||||
if (!(count % 16))
|
||||
printk("\n%04X: ", count);
|
||||
printk("%02X ", inb(count));
|
||||
pr_cont("%04X:", count);
|
||||
pr_cont(" %02X", inb(count));
|
||||
}
|
||||
printk("\n");
|
||||
pr_cont("\n");
|
||||
|
||||
printk("buffer0 dump:\n");
|
||||
netdev_dbg(dev, "buffer0 dump:\n");
|
||||
/* set up the address register */
|
||||
count = 0;
|
||||
outb((count >> 8) | RDDATAflag | AUTOINCflag, _ADDR_HI);
|
||||
|
@ -77,19 +77,15 @@ static void regdump(struct net_device *dev)
|
|||
for (count = 0; count < 256+32; count++)
|
||||
{
|
||||
if (!(count % 16))
|
||||
printk("\n%04X: ", count);
|
||||
pr_cont("%04X:", count);
|
||||
|
||||
/* copy the data */
|
||||
printk("%02X ", inb(_MEMDATA));
|
||||
pr_cont(" %02X", inb(_MEMDATA));
|
||||
}
|
||||
printk("\n");
|
||||
pr_cont("\n");
|
||||
#endif
|
||||
}
|
||||
|
||||
#else
|
||||
|
||||
static inline void regdump(struct net_device *dev) { }
|
||||
|
||||
#endif
|
||||
|
||||
|
||||
/*====================================================================*/
|
||||
|
@ -301,13 +297,13 @@ static int com20020_config(struct pcmcia_device *link)
|
|||
i = com20020_found(dev, 0); /* calls register_netdev */
|
||||
|
||||
if (i != 0) {
|
||||
dev_printk(KERN_NOTICE, &link->dev,
|
||||
"com20020_cs: com20020_found() failed\n");
|
||||
dev_notice(&link->dev,
|
||||
"com20020_found() failed\n");
|
||||
goto failed;
|
||||
}
|
||||
|
||||
dev_dbg(&link->dev,KERN_INFO "%s: port %#3lx, irq %d\n",
|
||||
dev->name, dev->base_addr, dev->irq);
|
||||
netdev_dbg(dev, "port %#3lx, irq %d\n",
|
||||
dev->base_addr, dev->irq);
|
||||
return 0;
|
||||
|
||||
failed:
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue