forge/linux-pinenote
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

perf ui browser: Add ui_browser__show counterpart: __hide

Browse source 
So that the common tasks of providing a helpline at __run entry and
destroying the window and releasing resourses at exit can be abstracted
away, reducing a bit more the coupling with libnewt.

Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Arnaldo Carvalho de Melo 2010-08-10 15:44:20 -03:00
commit 59e8fe32fc
7 changed files with 33 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

8
tools/perf/util/ui/browsers/annotate.c
View file

@ -141,10 +141,10 @@ static int annotate_browser__run(struct annotate_browser *self,
struct rb_node *nd;
struct hist_entry *he = self->b.priv;
if (ui_browser__show(&self->b, he->ms.sym->name) < 0)
if (ui_browser__show(&self->b, he->ms.sym->name,
"<- or ESC: exit, TAB/shift+TAB: cycle thru samples") < 0)
return -1;
ui_helpline__fpush("<- or ESC: exit, TAB/shift+TAB: cycle thru samples");
newtFormAddHotKey(self->b.form, NEWT_KEY_LEFT);
nd = self->curr_hot;
@ -177,9 +177,7 @@ static int annotate_browser__run(struct annotate_browser *self,
}
}
out:
newtFormDestroy(self->b.form);
newtPopWindow();
ui_helpline__pop();
ui_browser__hide(&self->b);
return 0;
}