forge/linux-pinenote
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

sctp: Do not reset the packet during sctp_packet_config().

Browse source 
sctp_packet_config() is called when getting the packet ready
for appending of chunks.  The function should not touch the
current state, since it's possible to ping-pong between two
transports when sending, and that can result packet corruption
followed by skb overlfow crash.

Reported-by: Thomas Dreibholz <dreibh@iem.uni-due.de>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Vlad Yasevich 2010-09-15 10:00:26 -04:00 • committed by David S. Miller
commit 4bdab43323
1 changed files with 0 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
net/sctp/output.c
View file

@ -92,7 +92,6 @@ struct sctp_packet *sctp_packet_config(struct sctp_packet *packet,
SCTP_DEBUG_PRINTK("%s: packet:%p vtag:0x%x\n", __func__, SCTP_DEBUG_PRINTK("%s: packet:%p vtag:0x%x\n", __func__,
packet, vtag); packet, vtag);
sctp_packet_reset(packet);
packet->vtag = vtag; packet->vtag = vtag;
if (ecn_capable && sctp_packet_empty(packet)) { if (ecn_capable && sctp_packet_empty(packet)) {