forge/linux-pinenote
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

btrfs: Mem leak in btrfs_get_acl()

Browse source 
It seems to me that we leak the memory allocated to 'value' in
btrfs_get_acl() if the call to posix_acl_from_xattr() fails.
Here's a patch that attempts to correct that problem.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Chris Mason <chris.mason@oracle.com>
This commit is contained in:
Jesper Juhl 2011-01-06 21:45:21 +00:00 • committed by Chris Mason
commit 42838bb265
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
fs/btrfs/acl.c
View file

@ -60,8 +60,10 @@ static struct posix_acl *btrfs_get_acl(struct inode *inode, int type)
size = __btrfs_getxattr(inode, name, value, size); size = __btrfs_getxattr(inode, name, value, size);
if (size > 0) { if (size > 0) {
acl = posix_acl_from_xattr(value, size); acl = posix_acl_from_xattr(value, size);
if (IS_ERR(acl)) if (IS_ERR(acl)) {
kfree(value);
return acl; return acl;
}
set_cached_acl(inode, type, acl); set_cached_acl(inode, type, acl);
} }
kfree(value); kfree(value);