forge/linux-pinenote
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

net: Xilinx: Deletion of unnecessary checks before two function calls

Browse source 
The functions kfree() and of_node_put() test whether their argument is NULL
and then return immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Markus Elfring 2014-11-20 14:47:12 +01:00 • committed by David S. Miller
commit 38a90e7ccb
2 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
drivers/net/ethernet/xilinx/ll_temac_main.c
View file

@ -224,8 +224,7 @@ static void temac_dma_bd_release(struct net_device *ndev)
dma_free_coherent(ndev->dev.parent, dma_free_coherent(ndev->dev.parent,
sizeof(*lp->tx_bd_v) * TX_BD_NUM, sizeof(*lp->tx_bd_v) * TX_BD_NUM,
lp->tx_bd_v, lp->tx_bd_p); lp->tx_bd_v, lp->tx_bd_p);
if (lp->rx_skb) kfree(lp->rx_skb);
kfree(lp->rx_skb);
} }
/** /**

3
drivers/net/ethernet/xilinx/xilinx_emaclite.c
View file

@ -1200,8 +1200,7 @@ static int xemaclite_of_remove(struct platform_device *of_dev)
unregister_netdev(ndev); unregister_netdev(ndev);
if (lp->phy_node) of_node_put(lp->phy_node);
of_node_put(lp->phy_node);
lp->phy_node = NULL; lp->phy_node = NULL;
xemaclite_remove_ndev(ndev); xemaclite_remove_ndev(ndev);