[media] m88ds3103: possible uninitialized scalar variable
It was possible that tuner_frequency variable, used for carrier offset compensation, was uninitialized. That happens when tuner .get_frequency() callback is not defined. Currently that case is not possible as only used tuner has this callback. Coverity CID 1166057: Uninitialized scalar variable (UNINIT) Signed-off-by: Antti Palosaari <crope@iki.fi> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
This commit is contained in:
parent
8a648fbbc1
commit
2f9dff3f39
1 changed files with 7 additions and 0 deletions
|
@ -271,6 +271,13 @@ static int m88ds3103_set_frontend(struct dvb_frontend *fe)
|
||||||
ret = fe->ops.tuner_ops.get_frequency(fe, &tuner_frequency);
|
ret = fe->ops.tuner_ops.get_frequency(fe, &tuner_frequency);
|
||||||
if (ret)
|
if (ret)
|
||||||
goto err;
|
goto err;
|
||||||
|
} else {
|
||||||
|
/*
|
||||||
|
* Use nominal target frequency as tuner driver does not provide
|
||||||
|
* actual frequency used. Carrier offset calculation is not
|
||||||
|
* valid.
|
||||||
|
*/
|
||||||
|
tuner_frequency = c->frequency;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* reset */
|
/* reset */
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue