forge/linux-pinenote
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

IB/iser: Fix redundant pointer check in dealloc flow

Browse source 
This bug was discovered by Smatch static checker run by Dan Carpenter.
If in free_rx_descriptors(), rx_descs are not NULL then the iser
device is definately not NULL, so no need to check it before
dereferencing it.

Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
This commit is contained in:
Sagi Grimberg 2013-08-15 17:04:42 +03:00 • committed by Roland Dreier
parent 27ae2d1ea5
commit 2e02d653fe
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
drivers/infiniband/ulp/iser/iser_initiator.c
View file

@ -310,7 +310,7 @@ void iser_free_rx_descriptors(struct iser_conn *ib_conn)
if (!ib_conn->rx_descs) if (!ib_conn->rx_descs)
goto free_login_buf; goto free_login_buf;
if (device && device->iser_free_rdma_reg_res) if (device->iser_free_rdma_reg_res)
device->iser_free_rdma_reg_res(ib_conn); device->iser_free_rdma_reg_res(ib_conn);
rx_desc = ib_conn->rx_descs; rx_desc = ib_conn->rx_descs;