[NETNS]: Fix /proc/net breakage
Well I clearly goofed when I added the initial network namespace support for /proc/net. Currently things work but there are odd details visible to user space, even when we have a single network namespace. Since we do not cache proc_dir_entry dentries at the moment we can just modify ->lookup to return a different directory inode depending on the network namespace of the process looking at /proc/net, replacing the current technique of using a magic and fragile follow_link method. To accomplish that this patch: - introduces a shadow_proc method to allow different dentries to be returned from proc_lookup. - Removes the old /proc/net follow_link magic - Fixes a weakness in our not caching of proc generic dentries. As shadow_proc uses a task struct to decided which dentry to return we can go back later and fix the proc generic caching without modifying any code that uses the shadow_proc method. Signed-off-by: Eric W. Biederman <ebiederm@xmission.com> Cc: "Rafael J. Wysocki" <rjw@sisk.pl> Cc: Pavel Machek <pavel@ucw.cz> Cc: Pavel Emelyanov <xemul@openvz.org> Cc: "David S. Miller" <davem@davemloft.net> Cc: Ingo Molnar <mingo@elte.hu> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
parent
e03ba84adb
commit
2b1e300a9d
3 changed files with 19 additions and 82 deletions
|
@ -48,6 +48,8 @@ typedef int (read_proc_t)(char *page, char **start, off_t off,
|
|||
typedef int (write_proc_t)(struct file *file, const char __user *buffer,
|
||||
unsigned long count, void *data);
|
||||
typedef int (get_info_t)(char *, char **, off_t, int);
|
||||
typedef struct proc_dir_entry *(shadow_proc_t)(struct task_struct *task,
|
||||
struct proc_dir_entry *pde);
|
||||
|
||||
struct proc_dir_entry {
|
||||
unsigned int low_ino;
|
||||
|
@ -79,6 +81,7 @@ struct proc_dir_entry {
|
|||
int pde_users; /* number of callers into module in progress */
|
||||
spinlock_t pde_unload_lock; /* proc_fops checks and pde_users bumps */
|
||||
struct completion *pde_unload_completion;
|
||||
shadow_proc_t *shadow_proc;
|
||||
};
|
||||
|
||||
struct kcore_list {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue