forge/linux-pinenote
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ASoC: davinci: vcif must be a module if SND_DAVINCI_SOC is

Browse source 
It is possible to configure a kernel with SND_DAVINCI_SOC=m and
SND_DM365_VOICE_CODEC=y, which results in a link error:

sound/built-in.o: In function `davinci_vcif_probe':
sound/soc/davinci/davinci-vcif.c:223: undefined reference to `davinci_soc_platform_register'

The best way to avoid this is to make SND_DM365_VOICE_CODEC
a tristate option that depends on SND_DAVINCI_SOC, so it
can only be a module or disabled when the base driver is
a loadable module

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Arnd Bergmann 2014-09-29 17:32:17 +02:00 • committed by Mark Brown
commit 19926c6de0
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
sound/soc/davinci/Kconfig
View file

@ -63,7 +63,8 @@ config SND_DM365_AIC3X_CODEC
Say Y if you want to add support for AIC3101 audio codec Say Y if you want to add support for AIC3101 audio codec
config SND_DM365_VOICE_CODEC config SND_DM365_VOICE_CODEC
bool "Voice Codec - CQ93VC" tristate "Voice Codec - CQ93VC"
depends on SND_DAVINCI_SOC
select MFD_DAVINCI_VOICECODEC select MFD_DAVINCI_VOICECODEC
select SND_DAVINCI_SOC_VCIF select SND_DAVINCI_SOC_VCIF
select SND_SOC_CQ0093VC select SND_SOC_CQ0093VC