forge/linux-pinenote
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

vrf: drop unnecessary dev refcnt changes

Browse source 
netdev_master_upper_dev_link/unlink already do a dev_hold/put on the
devices being linked, so no need to take another reference.

Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Nikolay Aleksandrov 2015-08-18 20:28:01 +03:00 • committed by David S. Miller
parent 954591b9f3
commit 17d95f5ee2
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
drivers/net/vrf.c
View file

@ -334,14 +334,12 @@ static struct slave *__vrf_find_slave_dev(struct slave_queue *queue,
/* inverse of __vrf_insert_slave */ /* inverse of __vrf_insert_slave */
static void __vrf_remove_slave(struct slave_queue *queue, struct slave *slave) static void __vrf_remove_slave(struct slave_queue *queue, struct slave *slave)
{ {
dev_put(slave->dev);
list_del(&slave->list); list_del(&slave->list);
queue->num_slaves--; queue->num_slaves--;
} }
static void __vrf_insert_slave(struct slave_queue *queue, struct slave *slave) static void __vrf_insert_slave(struct slave_queue *queue, struct slave *slave)
{ {
dev_hold(slave->dev);
list_add(&slave->list, &queue->all_slaves); list_add(&slave->list, &queue->all_slaves);
queue->num_slaves++; queue->num_slaves++;
} }