forge/linux-pinenote
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

powerpc/powernv: Fix little endian issues in OPAL error log code

Browse source 
Fix little endian issues with the OPAL error log code.

Signed-off-by: Anton Blanchard <anton@samba.org>
Reviewed-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
This commit is contained in:
Anton Blanchard 2014-04-22 15:01:25 +10:00 • committed by Benjamin Herrenschmidt
commit 14ad0c58d5
2 changed files with 9 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
arch/powerpc/include/asm/opal.h
View file

@ -859,7 +859,7 @@ int64_t opal_lpc_read(uint32_t chip_id, enum OpalLPCAddressType addr_type,
uint32_t addr, __be32 *data, uint32_t sz); uint32_t addr, __be32 *data, uint32_t sz);
int64_t opal_read_elog(uint64_t buffer, uint64_t size, uint64_t log_id); int64_t opal_read_elog(uint64_t buffer, uint64_t size, uint64_t log_id);
int64_t opal_get_elog_size(uint64_t *log_id, uint64_t *size, uint64_t *elog_type); int64_t opal_get_elog_size(__be64 *log_id, __be64 *size, __be64 *elog_type);
int64_t opal_write_elog(uint64_t buffer, uint64_t size, uint64_t offset); int64_t opal_write_elog(uint64_t buffer, uint64_t size, uint64_t offset);
int64_t opal_send_ack_elog(uint64_t log_id); int64_t opal_send_ack_elog(uint64_t log_id);
void opal_resend_pending_logs(void); void opal_resend_pending_logs(void);

9
arch/powerpc/platforms/powernv/opal-elog.c
View file

@ -238,18 +238,25 @@ static struct elog_obj *create_elog_obj(uint64_t id, size_t size, uint64_t type)
static void elog_work_fn(struct work_struct *work) static void elog_work_fn(struct work_struct *work)
{ {
__be64 size;
__be64 id;
__be64 type;
uint64_t elog_size; uint64_t elog_size;
uint64_t log_id; uint64_t log_id;
uint64_t elog_type; uint64_t elog_type;
int rc; int rc;
char name[2+16+1]; char name[2+16+1];
rc = opal_get_elog_size(&log_id, &elog_size, &elog_type); rc = opal_get_elog_size(&id, &size, &type);
if (rc != OPAL_SUCCESS) { if (rc != OPAL_SUCCESS) {
pr_err("ELOG: Opal log read failed\n"); pr_err("ELOG: Opal log read failed\n");
return; return;
} }
elog_size = be64_to_cpu(size);
log_id = be64_to_cpu(id);
elog_type = be64_to_cpu(type);
BUG_ON(elog_size > OPAL_MAX_ERRLOG_SIZE); BUG_ON(elog_size > OPAL_MAX_ERRLOG_SIZE);
if (elog_size >= OPAL_MAX_ERRLOG_SIZE) if (elog_size >= OPAL_MAX_ERRLOG_SIZE)