forge/linux-pinenote
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

perf annotate: Fix memory leaks in LOCK handling

Browse source 
The lock prefix handling fails to free the strdup()'d name as well as
the fields allocated by the instruction parsing.

Signed-off-by: Rabin Vincent <rabin@rab.in>
Cc: Paul Mackerras <paulus@samba.org>
Link: http://lkml.kernel.org/r/1421607621-15005-2-git-send-email-rabin@rab.in
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Rabin Vincent 2015-01-18 20:00:21 +01:00 • committed by Arnaldo Carvalho de Melo
commit 0fb9f2aab7
1 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
tools/perf/util/annotate.c
View file

@ -177,6 +177,8 @@ static int lock__parse(struct ins_operands *ops)
goto out_free_ops; goto out_free_ops;
ops->locked.ins = ins__find(name); ops->locked.ins = ins__find(name);
free(name);
if (ops->locked.ins == NULL) if (ops->locked.ins == NULL)
goto out_free_ops; goto out_free_ops;
@ -209,6 +211,13 @@ static int lock__scnprintf(struct ins *ins, char *bf, size_t size,
static void lock__delete(struct ins_operands *ops) static void lock__delete(struct ins_operands *ops)
{ {
struct ins *ins = ops->locked.ins;
if (ins && ins->ops->free)
ins->ops->free(ops->locked.ops);
else
ins__delete(ops->locked.ops);
zfree(&ops->locked.ops); zfree(&ops->locked.ops);
zfree(&ops->target.raw); zfree(&ops->target.raw);
zfree(&ops->target.name); zfree(&ops->target.name);