forge/linux-pinenote
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

xfs: remove the alloc_done argument to xfs_dialloc

Browse source 
We can simplify check the IO_agbp pointer for being non-NULL instead of
passing another argument through two layers of function calls.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
This commit is contained in:
Christoph Hellwig 2012-07-04 10:54:47 -04:00 • committed by Ben Myers
parent f2ecc5e453
commit 08358906ed
5 changed files with 10 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

3
fs/xfs/xfs_ialloc.c
View file

@ -895,7 +895,6 @@ xfs_dialloc(
umode_t mode,
int okalloc,
struct xfs_buf **IO_agbp,
boolean_t *alloc_done,
xfs_ino_t *inop)
{
struct xfs_buf *agbp;
@ -955,7 +954,6 @@ xfs_dialloc(
* or in which we can allocate some inodes. Iterate through the
* allocation groups upward, wrapping at the end.
*/
*alloc_done = B_FALSE;
while (!agi->agi_freecount) {
/*
* Don't do anything if we're not supposed to allocate
@ -982,7 +980,6 @@ xfs_dialloc(
* us again where we left off.
*/
ASSERT(be32_to_cpu(agi->agi_freecount) > 0);
*alloc_done = B_TRUE;
*IO_agbp = agbp;
*inop = NULLFSINO;
return 0;