forge/linux-pinenote
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

net: net: add a core netdev->tx_dropped counter

Browse source 
Dropping packets in __dev_queue_xmit() when transmit queue
is stopped (NIC TX ring buffer full or BQL limit reached) currently
outputs a syslog message.

It would be better to get a precise count of such events available in
netdevice stats so that monitoring tools can have a clue.

This extends the work done in caf586e5f2
("net: add a core netdev->rx_dropped counter")

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Eric Dumazet 2014-03-27 08:45:56 -07:00 • committed by David S. Miller
commit 015f0688f5
2 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
include/linux/netdevice.h
View file

@ -1311,9 +1311,10 @@ struct net_device {
int iflink; int iflink;
struct net_device_stats stats; struct net_device_stats stats;
atomic_long_t rx_dropped; /* dropped packets by core network
* Do not use this in drivers. /* dropped packets by core network, Do not use this in drivers */
*/ atomic_long_t rx_dropped;
atomic_long_t tx_dropped;
#ifdef CONFIG_WIRELESS_EXT #ifdef CONFIG_WIRELESS_EXT
/* List of functions to handle Wireless Extensions (instead of ioctl). /* List of functions to handle Wireless Extensions (instead of ioctl).

2
net/core/dev.c
View file

@ -2880,6 +2880,7 @@ recursion_alert:
rc = -ENETDOWN; rc = -ENETDOWN;
rcu_read_unlock_bh(); rcu_read_unlock_bh();
atomic_long_inc(&dev->tx_dropped);
kfree_skb(skb); kfree_skb(skb);
return rc; return rc;
out: out:
@ -6238,6 +6239,7 @@ struct rtnl_link_stats64 *dev_get_stats(struct net_device *dev,
netdev_stats_to_stats64(storage, &dev->stats); netdev_stats_to_stats64(storage, &dev->stats);
} }
storage->rx_dropped += atomic_long_read(&dev->rx_dropped); storage->rx_dropped += atomic_long_read(&dev->rx_dropped);
storage->tx_dropped += atomic_long_read(&dev->tx_dropped);
return storage; return storage;
} }
EXPORT_SYMBOL(dev_get_stats); EXPORT_SYMBOL(dev_get_stats);