| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | /*
 | 
					
						
							|  |  |  |  * Copyright (c) 2004 Topspin Communications.  All rights reserved. | 
					
						
							| 
									
										
										
										
											2006-09-22 15:22:46 -07:00
										 |  |  |  * Copyright (c) 2005 Voltaire, Inc. All rights reserved. | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  |  * Copyright (c) 2005 Sun Microsystems, Inc. All rights reserved. | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  |  * Copyright (c) 2008 Cisco. All rights reserved. | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  |  * | 
					
						
							|  |  |  |  * This software is available to you under a choice of one of two | 
					
						
							|  |  |  |  * licenses.  You may choose to be licensed under the terms of the GNU | 
					
						
							|  |  |  |  * General Public License (GPL) Version 2, available from the file | 
					
						
							|  |  |  |  * COPYING in the main directory of this source tree, or the | 
					
						
							|  |  |  |  * OpenIB.org BSD license below: | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  *     Redistribution and use in source and binary forms, with or | 
					
						
							|  |  |  |  *     without modification, are permitted provided that the following | 
					
						
							|  |  |  |  *     conditions are met: | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  *      - Redistributions of source code must retain the above | 
					
						
							|  |  |  |  *        copyright notice, this list of conditions and the following | 
					
						
							|  |  |  |  *        disclaimer. | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  *      - Redistributions in binary form must reproduce the above | 
					
						
							|  |  |  |  *        copyright notice, this list of conditions and the following | 
					
						
							|  |  |  |  *        disclaimer in the documentation and/or other materials | 
					
						
							|  |  |  |  *        provided with the distribution. | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, | 
					
						
							|  |  |  |  * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF | 
					
						
							|  |  |  |  * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND | 
					
						
							|  |  |  |  * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS | 
					
						
							|  |  |  |  * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN | 
					
						
							|  |  |  |  * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN | 
					
						
							|  |  |  |  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | 
					
						
							|  |  |  |  * SOFTWARE. | 
					
						
							|  |  |  |  */ | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | #include <linux/module.h>
 | 
					
						
							|  |  |  | #include <linux/init.h>
 | 
					
						
							|  |  |  | #include <linux/device.h>
 | 
					
						
							|  |  |  | #include <linux/err.h>
 | 
					
						
							|  |  |  | #include <linux/fs.h>
 | 
					
						
							|  |  |  | #include <linux/cdev.h>
 | 
					
						
							|  |  |  | #include <linux/dma-mapping.h>
 | 
					
						
							|  |  |  | #include <linux/poll.h>
 | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | #include <linux/mutex.h>
 | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | #include <linux/kref.h>
 | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | #include <linux/compat.h>
 | 
					
						
							| 
									
										
										
										
											2009-10-04 16:11:37 +04:00
										 |  |  | #include <linux/sched.h>
 | 
					
						
							| 
									
										
										
										
											2008-04-18 22:21:05 -04:00
										 |  |  | #include <linux/semaphore.h>
 | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							|  |  |  | #include <asm/uaccess.h>
 | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-08-25 13:40:04 -07:00
										 |  |  | #include <rdma/ib_mad.h>
 | 
					
						
							|  |  |  | #include <rdma/ib_user_mad.h>
 | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							|  |  |  | MODULE_AUTHOR("Roland Dreier"); | 
					
						
							|  |  |  | MODULE_DESCRIPTION("InfiniBand userspace MAD packet access"); | 
					
						
							|  |  |  | MODULE_LICENSE("Dual BSD/GPL"); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | enum { | 
					
						
							|  |  |  | 	IB_UMAD_MAX_PORTS  = 64, | 
					
						
							|  |  |  | 	IB_UMAD_MAX_AGENTS = 32, | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	IB_UMAD_MAJOR      = 231, | 
					
						
							|  |  |  | 	IB_UMAD_MINOR_BASE = 0 | 
					
						
							|  |  |  | }; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | /*
 | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:30 +00:00
										 |  |  |  * Our lifetime rules for these structs are the following: | 
					
						
							|  |  |  |  * device special file is opened, we take a reference on the | 
					
						
							|  |  |  |  * ib_umad_port's struct ib_umad_device. We drop these | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  |  * references in the corresponding close(). | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * In addition to references coming from open character devices, there | 
					
						
							|  |  |  |  * is one more reference to each ib_umad_device representing the | 
					
						
							|  |  |  |  * module's reference taken when allocating the ib_umad_device in | 
					
						
							|  |  |  |  * ib_umad_add_one(). | 
					
						
							|  |  |  |  * | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:30 +00:00
										 |  |  |  * When destroying an ib_umad_device, we drop the module's reference. | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  |  */ | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | struct ib_umad_port { | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:25 +00:00
										 |  |  | 	struct cdev           cdev; | 
					
						
							| 
									
										
										
										
											2008-02-22 00:13:36 +01:00
										 |  |  | 	struct device	      *dev; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:25 +00:00
										 |  |  | 	struct cdev           sm_cdev; | 
					
						
							| 
									
										
										
										
											2008-02-22 00:13:36 +01:00
										 |  |  | 	struct device	      *sm_dev; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	struct semaphore       sm_sem; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	struct mutex	       file_mutex; | 
					
						
							| 
									
										
										
										
											2005-11-03 12:01:18 -08:00
										 |  |  | 	struct list_head       file_list; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	struct ib_device      *ib_dev; | 
					
						
							|  |  |  | 	struct ib_umad_device *umad_dev; | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 	int                    dev_num; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	u8                     port_num; | 
					
						
							|  |  |  | }; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | struct ib_umad_device { | 
					
						
							|  |  |  | 	int                  start_port, end_port; | 
					
						
							|  |  |  | 	struct kref          ref; | 
					
						
							|  |  |  | 	struct ib_umad_port  port[0]; | 
					
						
							|  |  |  | }; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | struct ib_umad_file { | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	struct mutex		mutex; | 
					
						
							| 
									
										
										
										
											2005-11-10 10:18:23 -08:00
										 |  |  | 	struct ib_umad_port    *port; | 
					
						
							|  |  |  | 	struct list_head	recv_list; | 
					
						
							| 
									
										
										
										
											2006-07-20 11:25:50 +03:00
										 |  |  | 	struct list_head	send_list; | 
					
						
							| 
									
										
										
										
											2005-11-10 10:18:23 -08:00
										 |  |  | 	struct list_head	port_list; | 
					
						
							| 
									
										
										
										
											2006-07-20 11:25:50 +03:00
										 |  |  | 	spinlock_t		send_lock; | 
					
						
							| 
									
										
										
										
											2005-11-10 10:18:23 -08:00
										 |  |  | 	wait_queue_head_t	recv_wait; | 
					
						
							|  |  |  | 	struct ib_mad_agent    *agent[IB_UMAD_MAX_AGENTS]; | 
					
						
							|  |  |  | 	int			agents_dead; | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 	u8			use_pkey_index; | 
					
						
							|  |  |  | 	u8			already_used; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | }; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | struct ib_umad_packet { | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 	struct ib_mad_send_buf *msg; | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | 	struct ib_mad_recv_wc  *recv_wc; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	struct list_head   list; | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 	int		   length; | 
					
						
							|  |  |  | 	struct ib_user_mad mad; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | }; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | static struct class *umad_class; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | static const dev_t base_dev = MKDEV(IB_UMAD_MAJOR, IB_UMAD_MINOR_BASE); | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 
 | 
					
						
							|  |  |  | static DEFINE_SPINLOCK(port_lock); | 
					
						
							| 
									
										
										
										
											2007-04-02 12:45:16 -04:00
										 |  |  | static DECLARE_BITMAP(dev_map, IB_UMAD_MAX_PORTS); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							|  |  |  | static void ib_umad_add_one(struct ib_device *device); | 
					
						
							|  |  |  | static void ib_umad_remove_one(struct ib_device *device); | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | static void ib_umad_release_dev(struct kref *ref) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  | 	struct ib_umad_device *dev = | 
					
						
							|  |  |  | 		container_of(ref, struct ib_umad_device, ref); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	kfree(dev); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | static int hdr_size(struct ib_umad_file *file) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  | 	return file->use_pkey_index ? sizeof (struct ib_user_mad_hdr) : | 
					
						
							|  |  |  | 		sizeof (struct ib_user_mad_hdr_old); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | /* caller must hold file->mutex */ | 
					
						
							| 
									
										
										
										
											2005-11-10 10:18:23 -08:00
										 |  |  | static struct ib_mad_agent *__get_agent(struct ib_umad_file *file, int id) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  | 	return file->agents_dead ? NULL : file->agent[id]; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | static int queue_packet(struct ib_umad_file *file, | 
					
						
							|  |  |  | 			struct ib_mad_agent *agent, | 
					
						
							|  |  |  | 			struct ib_umad_packet *packet) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  | 	int ret = 1; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	mutex_lock(&file->mutex); | 
					
						
							| 
									
										
										
										
											2005-11-10 10:18:23 -08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 	for (packet->mad.hdr.id = 0; | 
					
						
							|  |  |  | 	     packet->mad.hdr.id < IB_UMAD_MAX_AGENTS; | 
					
						
							|  |  |  | 	     packet->mad.hdr.id++) | 
					
						
							| 
									
										
										
										
											2005-11-10 10:18:23 -08:00
										 |  |  | 		if (agent == __get_agent(file, packet->mad.hdr.id)) { | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 			list_add_tail(&packet->list, &file->recv_list); | 
					
						
							|  |  |  | 			wake_up_interruptible(&file->recv_wait); | 
					
						
							|  |  |  | 			ret = 0; | 
					
						
							|  |  |  | 			break; | 
					
						
							|  |  |  | 		} | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	mutex_unlock(&file->mutex); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							|  |  |  | 	return ret; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2006-07-20 11:25:50 +03:00
										 |  |  | static void dequeue_send(struct ib_umad_file *file, | 
					
						
							|  |  |  | 			 struct ib_umad_packet *packet) | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | { | 
					
						
							| 
									
										
										
										
											2006-07-20 11:25:50 +03:00
										 |  |  | 	spin_lock_irq(&file->send_lock); | 
					
						
							|  |  |  | 	list_del(&packet->list); | 
					
						
							|  |  |  | 	spin_unlock_irq(&file->send_lock); | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | } | 
					
						
							| 
									
										
										
										
											2006-07-20 11:25:50 +03:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | static void send_handler(struct ib_mad_agent *agent, | 
					
						
							|  |  |  | 			 struct ib_mad_send_wc *send_wc) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  | 	struct ib_umad_file *file = agent->context; | 
					
						
							| 
									
										
										
										
											2005-10-25 10:51:39 -07:00
										 |  |  | 	struct ib_umad_packet *packet = send_wc->send_buf->context[0]; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2006-07-20 11:25:50 +03:00
										 |  |  | 	dequeue_send(file, packet); | 
					
						
							| 
									
										
										
										
											2005-10-25 10:51:39 -07:00
										 |  |  | 	ib_destroy_ah(packet->msg->ah); | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 	ib_free_send_mad(packet->msg); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							|  |  |  | 	if (send_wc->status == IB_WC_RESP_TIMEOUT_ERR) { | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | 		packet->length = IB_MGMT_MAD_HDR; | 
					
						
							|  |  |  | 		packet->mad.hdr.status = ETIMEDOUT; | 
					
						
							|  |  |  | 		if (!queue_packet(file, agent, packet)) | 
					
						
							|  |  |  | 			return; | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 	} | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	kfree(packet); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static void recv_handler(struct ib_mad_agent *agent, | 
					
						
							|  |  |  | 			 struct ib_mad_recv_wc *mad_recv_wc) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  | 	struct ib_umad_file *file = agent->context; | 
					
						
							|  |  |  | 	struct ib_umad_packet *packet; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	if (mad_recv_wc->wc->status != IB_WC_SUCCESS) | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | 		goto err1; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | 	packet = kzalloc(sizeof *packet, GFP_KERNEL); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	if (!packet) | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | 		goto err1; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | 	packet->length = mad_recv_wc->mad_len; | 
					
						
							|  |  |  | 	packet->recv_wc = mad_recv_wc; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 	packet->mad.hdr.status	   = 0; | 
					
						
							|  |  |  | 	packet->mad.hdr.length	   = hdr_size(file) + mad_recv_wc->mad_len; | 
					
						
							|  |  |  | 	packet->mad.hdr.qpn	   = cpu_to_be32(mad_recv_wc->wc->src_qp); | 
					
						
							|  |  |  | 	packet->mad.hdr.lid	   = cpu_to_be16(mad_recv_wc->wc->slid); | 
					
						
							|  |  |  | 	packet->mad.hdr.sl	   = mad_recv_wc->wc->sl; | 
					
						
							|  |  |  | 	packet->mad.hdr.path_bits  = mad_recv_wc->wc->dlid_path_bits; | 
					
						
							|  |  |  | 	packet->mad.hdr.pkey_index = mad_recv_wc->wc->pkey_index; | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 	packet->mad.hdr.grh_present = !!(mad_recv_wc->wc->wc_flags & IB_WC_GRH); | 
					
						
							|  |  |  | 	if (packet->mad.hdr.grh_present) { | 
					
						
							| 
									
										
										
										
											2007-04-05 11:49:21 -07:00
										 |  |  | 		struct ib_ah_attr ah_attr; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 		ib_init_ah_from_wc(agent->device, agent->port_num, | 
					
						
							|  |  |  | 				   mad_recv_wc->wc, mad_recv_wc->recv_buf.grh, | 
					
						
							|  |  |  | 				   &ah_attr); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 		packet->mad.hdr.gid_index = ah_attr.grh.sgid_index; | 
					
						
							|  |  |  | 		packet->mad.hdr.hop_limit = ah_attr.grh.hop_limit; | 
					
						
							|  |  |  | 		packet->mad.hdr.traffic_class = ah_attr.grh.traffic_class; | 
					
						
							|  |  |  | 		memcpy(packet->mad.hdr.gid, &ah_attr.grh.dgid, 16); | 
					
						
							|  |  |  | 		packet->mad.hdr.flow_label = cpu_to_be32(ah_attr.grh.flow_label); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	if (queue_packet(file, agent, packet)) | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | 		goto err2; | 
					
						
							|  |  |  | 	return; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | err2: | 
					
						
							|  |  |  | 	kfree(packet); | 
					
						
							|  |  |  | err1: | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	ib_free_recv_mad(mad_recv_wc); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | static ssize_t copy_recv_mad(struct ib_umad_file *file, char __user *buf, | 
					
						
							|  |  |  | 			     struct ib_umad_packet *packet, size_t count) | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | { | 
					
						
							|  |  |  | 	struct ib_mad_recv_buf *recv_buf; | 
					
						
							|  |  |  | 	int left, seg_payload, offset, max_seg_payload; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	/* We need enough room to copy the first (or only) MAD segment. */ | 
					
						
							|  |  |  | 	recv_buf = &packet->recv_wc->recv_buf; | 
					
						
							|  |  |  | 	if ((packet->length <= sizeof (*recv_buf->mad) && | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 	     count < hdr_size(file) + packet->length) || | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | 	    (packet->length > sizeof (*recv_buf->mad) && | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 	     count < hdr_size(file) + sizeof (*recv_buf->mad))) | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | 		return -EINVAL; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 	if (copy_to_user(buf, &packet->mad, hdr_size(file))) | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | 		return -EFAULT; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 	buf += hdr_size(file); | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | 	seg_payload = min_t(int, packet->length, sizeof (*recv_buf->mad)); | 
					
						
							|  |  |  | 	if (copy_to_user(buf, recv_buf->mad, seg_payload)) | 
					
						
							|  |  |  | 		return -EFAULT; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	if (seg_payload < packet->length) { | 
					
						
							|  |  |  | 		/*
 | 
					
						
							|  |  |  | 		 * Multipacket RMPP MAD message. Copy remainder of message. | 
					
						
							|  |  |  | 		 * Note that last segment may have a shorter payload. | 
					
						
							|  |  |  | 		 */ | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 		if (count < hdr_size(file) + packet->length) { | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | 			/*
 | 
					
						
							|  |  |  | 			 * The buffer is too small, return the first RMPP segment, | 
					
						
							|  |  |  | 			 * which includes the RMPP message length. | 
					
						
							|  |  |  | 			 */ | 
					
						
							|  |  |  | 			return -ENOSPC; | 
					
						
							|  |  |  | 		} | 
					
						
							| 
									
										
										
										
											2006-03-28 16:40:04 -08:00
										 |  |  | 		offset = ib_get_mad_data_offset(recv_buf->mad->mad_hdr.mgmt_class); | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | 		max_seg_payload = sizeof (struct ib_mad) - offset; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 		for (left = packet->length - seg_payload, buf += seg_payload; | 
					
						
							|  |  |  | 		     left; left -= seg_payload, buf += seg_payload) { | 
					
						
							|  |  |  | 			recv_buf = container_of(recv_buf->list.next, | 
					
						
							|  |  |  | 						struct ib_mad_recv_buf, list); | 
					
						
							|  |  |  | 			seg_payload = min(left, max_seg_payload); | 
					
						
							|  |  |  | 			if (copy_to_user(buf, ((void *) recv_buf->mad) + offset, | 
					
						
							|  |  |  | 					 seg_payload)) | 
					
						
							|  |  |  | 				return -EFAULT; | 
					
						
							|  |  |  | 		} | 
					
						
							|  |  |  | 	} | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 	return hdr_size(file) + packet->length; | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | static ssize_t copy_send_mad(struct ib_umad_file *file, char __user *buf, | 
					
						
							|  |  |  | 			     struct ib_umad_packet *packet, size_t count) | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | { | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 	ssize_t size = hdr_size(file) + packet->length; | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | 
 | 
					
						
							|  |  |  | 	if (count < size) | 
					
						
							|  |  |  | 		return -EINVAL; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 	if (copy_to_user(buf, &packet->mad, hdr_size(file))) | 
					
						
							|  |  |  | 		return -EFAULT; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	buf += hdr_size(file); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	if (copy_to_user(buf, packet->mad.data, packet->length)) | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | 		return -EFAULT; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	return size; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | static ssize_t ib_umad_read(struct file *filp, char __user *buf, | 
					
						
							|  |  |  | 			    size_t count, loff_t *pos) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  | 	struct ib_umad_file *file = filp->private_data; | 
					
						
							|  |  |  | 	struct ib_umad_packet *packet; | 
					
						
							|  |  |  | 	ssize_t ret; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 	if (count < hdr_size(file)) | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 		return -EINVAL; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	mutex_lock(&file->mutex); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							|  |  |  | 	while (list_empty(&file->recv_list)) { | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 		mutex_unlock(&file->mutex); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							|  |  |  | 		if (filp->f_flags & O_NONBLOCK) | 
					
						
							|  |  |  | 			return -EAGAIN; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 		if (wait_event_interruptible(file->recv_wait, | 
					
						
							|  |  |  | 					     !list_empty(&file->recv_list))) | 
					
						
							|  |  |  | 			return -ERESTARTSYS; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 		mutex_lock(&file->mutex); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	packet = list_entry(file->recv_list.next, struct ib_umad_packet, list); | 
					
						
							|  |  |  | 	list_del(&packet->list); | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	mutex_unlock(&file->mutex); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | 	if (packet->recv_wc) | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 		ret = copy_recv_mad(file, buf, packet, count); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	else | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 		ret = copy_send_mad(file, buf, packet, count); | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 	if (ret < 0) { | 
					
						
							|  |  |  | 		/* Requeue packet */ | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 		mutex_lock(&file->mutex); | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 		list_add(&packet->list, &file->recv_list); | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 		mutex_unlock(&file->mutex); | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | 	} else { | 
					
						
							|  |  |  | 		if (packet->recv_wc) | 
					
						
							|  |  |  | 			ib_free_recv_mad(packet->recv_wc); | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 		kfree(packet); | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | 	} | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	return ret; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | static int copy_rmpp_mad(struct ib_mad_send_buf *msg, const char __user *buf) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  | 	int left, seg; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	/* Copy class specific header */ | 
					
						
							|  |  |  | 	if ((msg->hdr_len > IB_MGMT_RMPP_HDR) && | 
					
						
							|  |  |  | 	    copy_from_user(msg->mad + IB_MGMT_RMPP_HDR, buf + IB_MGMT_RMPP_HDR, | 
					
						
							|  |  |  | 			   msg->hdr_len - IB_MGMT_RMPP_HDR)) | 
					
						
							|  |  |  | 		return -EFAULT; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	/* All headers are in place.  Copy data segments. */ | 
					
						
							|  |  |  | 	for (seg = 1, left = msg->data_len, buf += msg->hdr_len; left > 0; | 
					
						
							|  |  |  | 	     seg++, left -= msg->seg_size, buf += msg->seg_size) { | 
					
						
							|  |  |  | 		if (copy_from_user(ib_get_rmpp_segment(msg, seg), buf, | 
					
						
							|  |  |  | 				   min(left, msg->seg_size))) | 
					
						
							|  |  |  | 			return -EFAULT; | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 	return 0; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2006-07-20 11:25:50 +03:00
										 |  |  | static int same_destination(struct ib_user_mad_hdr *hdr1, | 
					
						
							|  |  |  | 			    struct ib_user_mad_hdr *hdr2) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  | 	if (!hdr1->grh_present && !hdr2->grh_present) | 
					
						
							|  |  |  | 	   return (hdr1->lid == hdr2->lid); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	if (hdr1->grh_present && hdr2->grh_present) | 
					
						
							|  |  |  | 	   return !memcmp(hdr1->gid, hdr2->gid, 16); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	return 0; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static int is_duplicate(struct ib_umad_file *file, | 
					
						
							|  |  |  | 			struct ib_umad_packet *packet) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  | 	struct ib_umad_packet *sent_packet; | 
					
						
							|  |  |  | 	struct ib_mad_hdr *sent_hdr, *hdr; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	hdr = (struct ib_mad_hdr *) packet->mad.data; | 
					
						
							|  |  |  | 	list_for_each_entry(sent_packet, &file->send_list, list) { | 
					
						
							|  |  |  | 		sent_hdr = (struct ib_mad_hdr *) sent_packet->mad.data; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 		if ((hdr->tid != sent_hdr->tid) || | 
					
						
							|  |  |  | 		    (hdr->mgmt_class != sent_hdr->mgmt_class)) | 
					
						
							|  |  |  | 			continue; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 		/*
 | 
					
						
							|  |  |  | 		 * No need to be overly clever here.  If two new operations have | 
					
						
							|  |  |  | 		 * the same TID, reject the second as a duplicate.  This is more | 
					
						
							|  |  |  | 		 * restrictive than required by the spec. | 
					
						
							|  |  |  | 		 */ | 
					
						
							|  |  |  | 		if (!ib_response_mad((struct ib_mad *) hdr)) { | 
					
						
							|  |  |  | 			if (!ib_response_mad((struct ib_mad *) sent_hdr)) | 
					
						
							|  |  |  | 				return 1; | 
					
						
							|  |  |  | 			continue; | 
					
						
							|  |  |  | 		} else if (!ib_response_mad((struct ib_mad *) sent_hdr)) | 
					
						
							|  |  |  | 			continue; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 		if (same_destination(&packet->mad.hdr, &sent_packet->mad.hdr)) | 
					
						
							|  |  |  | 			return 1; | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	return 0; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | static ssize_t ib_umad_write(struct file *filp, const char __user *buf, | 
					
						
							|  |  |  | 			     size_t count, loff_t *pos) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  | 	struct ib_umad_file *file = filp->private_data; | 
					
						
							|  |  |  | 	struct ib_umad_packet *packet; | 
					
						
							|  |  |  | 	struct ib_mad_agent *agent; | 
					
						
							|  |  |  | 	struct ib_ah_attr ah_attr; | 
					
						
							| 
									
										
										
										
											2005-10-25 10:51:39 -07:00
										 |  |  | 	struct ib_ah *ah; | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 	struct ib_rmpp_mad *rmpp_mad; | 
					
						
							| 
									
										
										
										
											2005-08-13 21:05:57 -07:00
										 |  |  | 	__be64 *tid; | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | 	int ret, data_len, hdr_len, copy_offset, rmpp_active; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 	if (count < hdr_size(file) + IB_MGMT_RMPP_HDR) | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 		return -EINVAL; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | 	packet = kzalloc(sizeof *packet + IB_MGMT_RMPP_HDR, GFP_KERNEL); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	if (!packet) | 
					
						
							|  |  |  | 		return -ENOMEM; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 	if (copy_from_user(&packet->mad, buf, hdr_size(file))) { | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 		ret = -EFAULT; | 
					
						
							|  |  |  | 		goto err; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 	if (packet->mad.hdr.id < 0 || | 
					
						
							|  |  |  | 	    packet->mad.hdr.id >= IB_UMAD_MAX_AGENTS) { | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 		ret = -EINVAL; | 
					
						
							|  |  |  | 		goto err; | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 	buf += hdr_size(file); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	if (copy_from_user(packet->mad.data, buf, IB_MGMT_RMPP_HDR)) { | 
					
						
							|  |  |  | 		ret = -EFAULT; | 
					
						
							|  |  |  | 		goto err; | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	mutex_lock(&file->mutex); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-11-10 10:18:23 -08:00
										 |  |  | 	agent = __get_agent(file, packet->mad.hdr.id); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	if (!agent) { | 
					
						
							|  |  |  | 		ret = -EINVAL; | 
					
						
							|  |  |  | 		goto err_up; | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	memset(&ah_attr, 0, sizeof ah_attr); | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 	ah_attr.dlid          = be16_to_cpu(packet->mad.hdr.lid); | 
					
						
							|  |  |  | 	ah_attr.sl            = packet->mad.hdr.sl; | 
					
						
							|  |  |  | 	ah_attr.src_path_bits = packet->mad.hdr.path_bits; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	ah_attr.port_num      = file->port->port_num; | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 	if (packet->mad.hdr.grh_present) { | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 		ah_attr.ah_flags = IB_AH_GRH; | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 		memcpy(ah_attr.grh.dgid.raw, packet->mad.hdr.gid, 16); | 
					
						
							| 
									
										
										
										
											2007-04-05 11:49:21 -07:00
										 |  |  | 		ah_attr.grh.sgid_index	   = packet->mad.hdr.gid_index; | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:50 +00:00
										 |  |  | 		ah_attr.grh.flow_label	   = be32_to_cpu(packet->mad.hdr.flow_label); | 
					
						
							|  |  |  | 		ah_attr.grh.hop_limit	   = packet->mad.hdr.hop_limit; | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 		ah_attr.grh.traffic_class  = packet->mad.hdr.traffic_class; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-10-25 10:51:39 -07:00
										 |  |  | 	ah = ib_create_ah(agent->qp->pd, &ah_attr); | 
					
						
							|  |  |  | 	if (IS_ERR(ah)) { | 
					
						
							|  |  |  | 		ret = PTR_ERR(ah); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 		goto err_up; | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 	rmpp_mad = (struct ib_rmpp_mad *) packet->mad.data; | 
					
						
							| 
									
										
										
										
											2006-03-28 16:40:04 -08:00
										 |  |  | 	hdr_len = ib_get_mad_data_offset(rmpp_mad->mad_hdr.mgmt_class); | 
					
						
							|  |  |  | 	if (!ib_is_mad_class_rmpp(rmpp_mad->mad_hdr.mgmt_class)) { | 
					
						
							|  |  |  | 		copy_offset = IB_MGMT_MAD_HDR; | 
					
						
							|  |  |  | 		rmpp_active = 0; | 
					
						
							|  |  |  | 	} else { | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | 		copy_offset = IB_MGMT_RMPP_HDR; | 
					
						
							|  |  |  | 		rmpp_active = ib_get_rmpp_flags(&rmpp_mad->rmpp_hdr) & | 
					
						
							|  |  |  | 			      IB_MGMT_RMPP_FLAG_ACTIVE; | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 	data_len = count - hdr_size(file) - hdr_len; | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 	packet->msg = ib_create_send_mad(agent, | 
					
						
							|  |  |  | 					 be32_to_cpu(packet->mad.hdr.qpn), | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 					 packet->mad.hdr.pkey_index, rmpp_active, | 
					
						
							|  |  |  | 					 hdr_len, data_len, GFP_KERNEL); | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 	if (IS_ERR(packet->msg)) { | 
					
						
							|  |  |  | 		ret = PTR_ERR(packet->msg); | 
					
						
							|  |  |  | 		goto err_ah; | 
					
						
							|  |  |  | 	} | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:50 +00:00
										 |  |  | 	packet->msg->ah		= ah; | 
					
						
							| 
									
										
										
										
											2005-10-25 10:51:39 -07:00
										 |  |  | 	packet->msg->timeout_ms = packet->mad.hdr.timeout_ms; | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:50 +00:00
										 |  |  | 	packet->msg->retries	= packet->mad.hdr.retries; | 
					
						
							| 
									
										
										
										
											2005-10-25 10:51:39 -07:00
										 |  |  | 	packet->msg->context[0] = packet; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | 	/* Copy MAD header.  Any RMPP header is already in place. */ | 
					
						
							| 
									
										
										
										
											2005-10-27 20:48:11 -07:00
										 |  |  | 	memcpy(packet->msg->mad, packet->mad.data, IB_MGMT_MAD_HDR); | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | 
 | 
					
						
							|  |  |  | 	if (!rmpp_active) { | 
					
						
							|  |  |  | 		if (copy_from_user(packet->msg->mad + copy_offset, | 
					
						
							|  |  |  | 				   buf + copy_offset, | 
					
						
							|  |  |  | 				   hdr_len + data_len - copy_offset)) { | 
					
						
							|  |  |  | 			ret = -EFAULT; | 
					
						
							|  |  |  | 			goto err_msg; | 
					
						
							|  |  |  | 		} | 
					
						
							|  |  |  | 	} else { | 
					
						
							|  |  |  | 		ret = copy_rmpp_mad(packet->msg, buf); | 
					
						
							|  |  |  | 		if (ret) | 
					
						
							|  |  |  | 			goto err_msg; | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	/*
 | 
					
						
							| 
									
										
										
										
											2006-07-20 11:25:50 +03:00
										 |  |  | 	 * Set the high-order part of the transaction ID to make MADs from | 
					
						
							|  |  |  | 	 * different agents unique, and allow routing responses back to the | 
					
						
							|  |  |  | 	 * original requestor. | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 	 */ | 
					
						
							| 
									
										
										
										
											2006-07-20 11:25:50 +03:00
										 |  |  | 	if (!ib_response_mad(packet->msg->mad)) { | 
					
						
							| 
									
										
										
										
											2005-10-27 20:33:43 -07:00
										 |  |  | 		tid = &((struct ib_mad_hdr *) packet->msg->mad)->tid; | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 		*tid = cpu_to_be64(((u64) agent->hi_tid) << 32 | | 
					
						
							|  |  |  | 				   (be64_to_cpup(tid) & 0xffffffff)); | 
					
						
							| 
									
										
										
										
											2006-07-20 11:25:50 +03:00
										 |  |  | 		rmpp_mad->mad_hdr.tid = *tid; | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	spin_lock_irq(&file->send_lock); | 
					
						
							|  |  |  | 	ret = is_duplicate(file, packet); | 
					
						
							|  |  |  | 	if (!ret) | 
					
						
							|  |  |  | 		list_add_tail(&packet->list, &file->send_list); | 
					
						
							|  |  |  | 	spin_unlock_irq(&file->send_lock); | 
					
						
							|  |  |  | 	if (ret) { | 
					
						
							|  |  |  | 		ret = -EINVAL; | 
					
						
							|  |  |  | 		goto err_msg; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-10-25 10:51:39 -07:00
										 |  |  | 	ret = ib_post_send_mad(packet->msg, NULL); | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 	if (ret) | 
					
						
							| 
									
										
										
										
											2006-07-20 11:25:50 +03:00
										 |  |  | 		goto err_send; | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	mutex_unlock(&file->mutex); | 
					
						
							| 
									
										
										
										
											2005-10-27 20:48:11 -07:00
										 |  |  | 	return count; | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2006-07-20 11:25:50 +03:00
										 |  |  | err_send: | 
					
						
							|  |  |  | 	dequeue_send(file, packet); | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | err_msg: | 
					
						
							|  |  |  | 	ib_free_send_mad(packet->msg); | 
					
						
							|  |  |  | err_ah: | 
					
						
							| 
									
										
										
										
											2005-10-25 10:51:39 -07:00
										 |  |  | 	ib_destroy_ah(ah); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | err_up: | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	mutex_unlock(&file->mutex); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | err: | 
					
						
							|  |  |  | 	kfree(packet); | 
					
						
							|  |  |  | 	return ret; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static unsigned int ib_umad_poll(struct file *filp, struct poll_table_struct *wait) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  | 	struct ib_umad_file *file = filp->private_data; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	/* we will always be able to post a MAD send */ | 
					
						
							|  |  |  | 	unsigned int mask = POLLOUT | POLLWRNORM; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	poll_wait(filp, &file->recv_wait, wait); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	if (!list_empty(&file->recv_list)) | 
					
						
							|  |  |  | 		mask |= POLLIN | POLLRDNORM; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	return mask; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | static int ib_umad_reg_agent(struct ib_umad_file *file, void __user *arg, | 
					
						
							|  |  |  | 			     int compat_method_mask) | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | { | 
					
						
							|  |  |  | 	struct ib_user_mad_reg_req ureq; | 
					
						
							|  |  |  | 	struct ib_mad_reg_req req; | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	struct ib_mad_agent *agent = NULL; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	int agent_id; | 
					
						
							|  |  |  | 	int ret; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	mutex_lock(&file->port->file_mutex); | 
					
						
							|  |  |  | 	mutex_lock(&file->mutex); | 
					
						
							| 
									
										
										
										
											2005-11-03 12:01:18 -08:00
										 |  |  | 
 | 
					
						
							|  |  |  | 	if (!file->port->ib_dev) { | 
					
						
							|  |  |  | 		ret = -EPIPE; | 
					
						
							|  |  |  | 		goto out; | 
					
						
							|  |  |  | 	} | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 	if (copy_from_user(&ureq, arg, sizeof ureq)) { | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 		ret = -EFAULT; | 
					
						
							|  |  |  | 		goto out; | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	if (ureq.qpn != 0 && ureq.qpn != 1) { | 
					
						
							|  |  |  | 		ret = -EINVAL; | 
					
						
							|  |  |  | 		goto out; | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	for (agent_id = 0; agent_id < IB_UMAD_MAX_AGENTS; ++agent_id) | 
					
						
							| 
									
										
										
										
											2005-11-10 10:18:23 -08:00
										 |  |  | 		if (!__get_agent(file, agent_id)) | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 			goto found; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	ret = -ENOMEM; | 
					
						
							|  |  |  | 	goto out; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | found: | 
					
						
							| 
									
										
										
										
											2005-04-16 15:26:11 -07:00
										 |  |  | 	if (ureq.mgmt_class) { | 
					
						
							|  |  |  | 		req.mgmt_class         = ureq.mgmt_class; | 
					
						
							|  |  |  | 		req.mgmt_class_version = ureq.mgmt_class_version; | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 		memcpy(req.oui, ureq.oui, sizeof req.oui); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 		if (compat_method_mask) { | 
					
						
							|  |  |  | 			u32 *umm = (u32 *) ureq.method_mask; | 
					
						
							|  |  |  | 			int i; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 			for (i = 0; i < BITS_TO_LONGS(IB_MGMT_MAX_METHODS); ++i) | 
					
						
							|  |  |  | 				req.method_mask[i] = | 
					
						
							|  |  |  | 					umm[i * 2] | ((u64) umm[i * 2 + 1] << 32); | 
					
						
							|  |  |  | 		} else | 
					
						
							|  |  |  | 			memcpy(req.method_mask, ureq.method_mask, | 
					
						
							|  |  |  | 			       sizeof req.method_mask); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:26:11 -07:00
										 |  |  | 	} | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							|  |  |  | 	agent = ib_register_mad_agent(file->port->ib_dev, file->port->port_num, | 
					
						
							|  |  |  | 				      ureq.qpn ? IB_QPT_GSI : IB_QPT_SMI, | 
					
						
							| 
									
										
										
										
											2005-04-16 15:26:11 -07:00
										 |  |  | 				      ureq.mgmt_class ? &req : NULL, | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | 				      ureq.rmpp_version, | 
					
						
							|  |  |  | 				      send_handler, recv_handler, file); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	if (IS_ERR(agent)) { | 
					
						
							|  |  |  | 		ret = PTR_ERR(agent); | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 		agent = NULL; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 		goto out; | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	if (put_user(agent_id, | 
					
						
							|  |  |  | 		     (u32 __user *) (arg + offsetof(struct ib_user_mad_reg_req, id)))) { | 
					
						
							|  |  |  | 		ret = -EFAULT; | 
					
						
							| 
									
										
										
										
											2005-11-09 09:58:10 -08:00
										 |  |  | 		goto out; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 	if (!file->already_used) { | 
					
						
							|  |  |  | 		file->already_used = 1; | 
					
						
							|  |  |  | 		if (!file->use_pkey_index) { | 
					
						
							|  |  |  | 			printk(KERN_WARNING "user_mad: process %s did not enable " | 
					
						
							|  |  |  | 			       "P_Key index support.\n", current->comm); | 
					
						
							|  |  |  | 			printk(KERN_WARNING "user_mad:   Documentation/infiniband/user_mad.txt " | 
					
						
							|  |  |  | 			       "has info on the new ABI.\n"); | 
					
						
							|  |  |  | 		} | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-11-07 10:41:29 -08:00
										 |  |  | 	file->agent[agent_id] = agent; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	ret = 0; | 
					
						
							| 
									
										
										
										
											2005-11-07 10:41:29 -08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | out: | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	mutex_unlock(&file->mutex); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	if (ret && agent) | 
					
						
							|  |  |  | 		ib_unregister_mad_agent(agent); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	mutex_unlock(&file->port->file_mutex); | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	return ret; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | static int ib_umad_unreg_agent(struct ib_umad_file *file, u32 __user *arg) | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | { | 
					
						
							| 
									
										
										
										
											2005-11-07 10:41:29 -08:00
										 |  |  | 	struct ib_mad_agent *agent = NULL; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	u32 id; | 
					
						
							|  |  |  | 	int ret = 0; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 	if (get_user(id, arg)) | 
					
						
							| 
									
										
										
										
											2005-11-07 10:41:29 -08:00
										 |  |  | 		return -EFAULT; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	mutex_lock(&file->port->file_mutex); | 
					
						
							|  |  |  | 	mutex_lock(&file->mutex); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-11-10 10:18:23 -08:00
										 |  |  | 	if (id < 0 || id >= IB_UMAD_MAX_AGENTS || !__get_agent(file, id)) { | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 		ret = -EINVAL; | 
					
						
							|  |  |  | 		goto out; | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-11-07 10:41:29 -08:00
										 |  |  | 	agent = file->agent[id]; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	file->agent[id] = NULL; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | out: | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	mutex_unlock(&file->mutex); | 
					
						
							| 
									
										
										
										
											2005-11-07 10:41:29 -08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-11-09 09:58:10 -08:00
										 |  |  | 	if (agent) | 
					
						
							| 
									
										
										
										
											2005-11-07 10:41:29 -08:00
										 |  |  | 		ib_unregister_mad_agent(agent); | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	mutex_unlock(&file->port->file_mutex); | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	return ret; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | static long ib_umad_enable_pkey(struct ib_umad_file *file) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  | 	int ret = 0; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	mutex_lock(&file->mutex); | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 	if (file->already_used) | 
					
						
							|  |  |  | 		ret = -EINVAL; | 
					
						
							|  |  |  | 	else | 
					
						
							|  |  |  | 		file->use_pkey_index = 1; | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	mutex_unlock(&file->mutex); | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 
 | 
					
						
							|  |  |  | 	return ret; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-07-27 11:45:42 -07:00
										 |  |  | static long ib_umad_ioctl(struct file *filp, unsigned int cmd, | 
					
						
							|  |  |  | 			  unsigned long arg) | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | { | 
					
						
							|  |  |  | 	switch (cmd) { | 
					
						
							|  |  |  | 	case IB_USER_MAD_REGISTER_AGENT: | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 		return ib_umad_reg_agent(filp->private_data, (void __user *) arg, 0); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	case IB_USER_MAD_UNREGISTER_AGENT: | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 		return ib_umad_unreg_agent(filp->private_data, (__u32 __user *) arg); | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | 	case IB_USER_MAD_ENABLE_PKEY: | 
					
						
							|  |  |  | 		return ib_umad_enable_pkey(filp->private_data); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	default: | 
					
						
							|  |  |  | 		return -ENOIOCTLCMD; | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | #ifdef CONFIG_COMPAT
 | 
					
						
							|  |  |  | static long ib_umad_compat_ioctl(struct file *filp, unsigned int cmd, | 
					
						
							|  |  |  | 				 unsigned long arg) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  | 	switch (cmd) { | 
					
						
							|  |  |  | 	case IB_USER_MAD_REGISTER_AGENT: | 
					
						
							|  |  |  | 		return ib_umad_reg_agent(filp->private_data, compat_ptr(arg), 1); | 
					
						
							|  |  |  | 	case IB_USER_MAD_UNREGISTER_AGENT: | 
					
						
							|  |  |  | 		return ib_umad_unreg_agent(filp->private_data, compat_ptr(arg)); | 
					
						
							|  |  |  | 	case IB_USER_MAD_ENABLE_PKEY: | 
					
						
							|  |  |  | 		return ib_umad_enable_pkey(filp->private_data); | 
					
						
							|  |  |  | 	default: | 
					
						
							|  |  |  | 		return -ENOIOCTLCMD; | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | #endif
 | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2008-07-11 13:54:40 -07:00
										 |  |  | /*
 | 
					
						
							|  |  |  |  * ib_umad_open() does not need the BKL: | 
					
						
							|  |  |  |  * | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:30 +00:00
										 |  |  |  *  - the ib_umad_port structures are properly reference counted, and | 
					
						
							| 
									
										
										
										
											2008-07-11 13:54:40 -07:00
										 |  |  |  *    everything else is purely local to the file being created, so | 
					
						
							|  |  |  |  *    races against other open calls are not a problem; | 
					
						
							|  |  |  |  *  - the ioctl method does not affect any global state outside of the | 
					
						
							|  |  |  |  *    file structure being operated on; | 
					
						
							|  |  |  |  */ | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | static int ib_umad_open(struct inode *inode, struct file *filp) | 
					
						
							|  |  |  | { | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 	struct ib_umad_port *port; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	struct ib_umad_file *file; | 
					
						
							| 
									
										
										
										
											2005-11-03 12:01:18 -08:00
										 |  |  | 	int ret = 0; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:30 +00:00
										 |  |  | 	port = container_of(inode->i_cdev, struct ib_umad_port, cdev); | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 	if (port) | 
					
						
							|  |  |  | 		kref_get(&port->umad_dev->ref); | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:30 +00:00
										 |  |  | 	else | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 		return -ENXIO; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	mutex_lock(&port->file_mutex); | 
					
						
							| 
									
										
										
										
											2005-11-03 12:01:18 -08:00
										 |  |  | 
 | 
					
						
							|  |  |  | 	if (!port->ib_dev) { | 
					
						
							|  |  |  | 		ret = -ENXIO; | 
					
						
							|  |  |  | 		goto out; | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-10-27 20:48:11 -07:00
										 |  |  | 	file = kzalloc(sizeof *file, GFP_KERNEL); | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 	if (!file) { | 
					
						
							|  |  |  | 		kref_put(&port->umad_dev->ref, ib_umad_release_dev); | 
					
						
							| 
									
										
										
										
											2005-11-03 12:01:18 -08:00
										 |  |  | 		ret = -ENOMEM; | 
					
						
							|  |  |  | 		goto out; | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 	} | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	mutex_init(&file->mutex); | 
					
						
							| 
									
										
										
										
											2006-07-20 11:25:50 +03:00
										 |  |  | 	spin_lock_init(&file->send_lock); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	INIT_LIST_HEAD(&file->recv_list); | 
					
						
							| 
									
										
										
										
											2006-07-20 11:25:50 +03:00
										 |  |  | 	INIT_LIST_HEAD(&file->send_list); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	init_waitqueue_head(&file->recv_wait); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	file->port = port; | 
					
						
							|  |  |  | 	filp->private_data = file; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-11-03 12:01:18 -08:00
										 |  |  | 	list_add_tail(&file->port_list, &port->file_list); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | out: | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	mutex_unlock(&port->file_mutex); | 
					
						
							| 
									
										
										
										
											2005-11-03 12:01:18 -08:00
										 |  |  | 	return ret; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static int ib_umad_close(struct inode *inode, struct file *filp) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  | 	struct ib_umad_file *file = filp->private_data; | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 	struct ib_umad_device *dev = file->port->umad_dev; | 
					
						
							| 
									
										
										
										
											2005-05-25 12:31:30 -07:00
										 |  |  | 	struct ib_umad_packet *packet, *tmp; | 
					
						
							| 
									
										
										
										
											2005-11-10 10:18:23 -08:00
										 |  |  | 	int already_dead; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	int i; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	mutex_lock(&file->port->file_mutex); | 
					
						
							|  |  |  | 	mutex_lock(&file->mutex); | 
					
						
							| 
									
										
										
										
											2005-11-10 10:18:23 -08:00
										 |  |  | 
 | 
					
						
							|  |  |  | 	already_dead = file->agents_dead; | 
					
						
							|  |  |  | 	file->agents_dead = 1; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | 	list_for_each_entry_safe(packet, tmp, &file->recv_list, list) { | 
					
						
							|  |  |  | 		if (packet->recv_wc) | 
					
						
							|  |  |  | 			ib_free_recv_mad(packet->recv_wc); | 
					
						
							| 
									
										
										
										
											2005-05-25 12:31:30 -07:00
										 |  |  | 		kfree(packet); | 
					
						
							| 
									
										
										
										
											2006-03-03 21:54:13 -08:00
										 |  |  | 	} | 
					
						
							| 
									
										
										
										
											2005-05-25 12:31:30 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-11-03 12:01:18 -08:00
										 |  |  | 	list_del(&file->port_list); | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	mutex_unlock(&file->mutex); | 
					
						
							| 
									
										
										
										
											2005-11-10 10:18:23 -08:00
										 |  |  | 
 | 
					
						
							|  |  |  | 	if (!already_dead) | 
					
						
							|  |  |  | 		for (i = 0; i < IB_UMAD_MAX_AGENTS; ++i) | 
					
						
							|  |  |  | 			if (file->agent[i]) | 
					
						
							|  |  |  | 				ib_unregister_mad_agent(file->agent[i]); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	mutex_unlock(&file->port->file_mutex); | 
					
						
							| 
									
										
										
										
											2005-11-10 10:18:23 -08:00
										 |  |  | 
 | 
					
						
							|  |  |  | 	kfree(file); | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 	kref_put(&dev->ref, ib_umad_release_dev); | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	return 0; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2007-02-12 00:55:32 -08:00
										 |  |  | static const struct file_operations umad_fops = { | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:50 +00:00
										 |  |  | 	.owner		= THIS_MODULE, | 
					
						
							|  |  |  | 	.read		= ib_umad_read, | 
					
						
							|  |  |  | 	.write		= ib_umad_write, | 
					
						
							|  |  |  | 	.poll		= ib_umad_poll, | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	.unlocked_ioctl = ib_umad_ioctl, | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | #ifdef CONFIG_COMPAT
 | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:50 +00:00
										 |  |  | 	.compat_ioctl	= ib_umad_compat_ioctl, | 
					
						
							| 
									
										
										
										
											2007-10-09 19:59:15 -07:00
										 |  |  | #endif
 | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:50 +00:00
										 |  |  | 	.open		= ib_umad_open, | 
					
						
							|  |  |  | 	.release	= ib_umad_close | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | }; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static int ib_umad_sm_open(struct inode *inode, struct file *filp) | 
					
						
							|  |  |  | { | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 	struct ib_umad_port *port; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	struct ib_port_modify props = { | 
					
						
							|  |  |  | 		.set_port_cap_mask = IB_PORT_SM | 
					
						
							|  |  |  | 	}; | 
					
						
							|  |  |  | 	int ret; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:30 +00:00
										 |  |  | 	port = container_of(inode->i_cdev, struct ib_umad_port, sm_cdev); | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 	if (port) | 
					
						
							|  |  |  | 		kref_get(&port->umad_dev->ref); | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:30 +00:00
										 |  |  | 	else | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 		return -ENXIO; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	if (filp->f_flags & O_NONBLOCK) { | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 		if (down_trylock(&port->sm_sem)) { | 
					
						
							|  |  |  | 			ret = -EAGAIN; | 
					
						
							|  |  |  | 			goto fail; | 
					
						
							|  |  |  | 		} | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	} else { | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 		if (down_interruptible(&port->sm_sem)) { | 
					
						
							|  |  |  | 			ret = -ERESTARTSYS; | 
					
						
							|  |  |  | 			goto fail; | 
					
						
							|  |  |  | 		} | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	ret = ib_modify_port(port->ib_dev, port->port_num, 0, &props); | 
					
						
							|  |  |  | 	if (ret) { | 
					
						
							|  |  |  | 		up(&port->sm_sem); | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 		goto fail; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	filp->private_data = port; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	return 0; | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 
 | 
					
						
							|  |  |  | fail: | 
					
						
							|  |  |  | 	kref_put(&port->umad_dev->ref, ib_umad_release_dev); | 
					
						
							|  |  |  | 	return ret; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static int ib_umad_sm_close(struct inode *inode, struct file *filp) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  | 	struct ib_umad_port *port = filp->private_data; | 
					
						
							|  |  |  | 	struct ib_port_modify props = { | 
					
						
							|  |  |  | 		.clr_port_cap_mask = IB_PORT_SM | 
					
						
							|  |  |  | 	}; | 
					
						
							| 
									
										
										
										
											2005-11-03 12:01:18 -08:00
										 |  |  | 	int ret = 0; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	mutex_lock(&port->file_mutex); | 
					
						
							| 
									
										
										
										
											2005-11-03 12:01:18 -08:00
										 |  |  | 	if (port->ib_dev) | 
					
						
							|  |  |  | 		ret = ib_modify_port(port->ib_dev, port->port_num, 0, &props); | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	mutex_unlock(&port->file_mutex); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							|  |  |  | 	up(&port->sm_sem); | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 	kref_put(&port->umad_dev->ref, ib_umad_release_dev); | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	return ret; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2007-02-12 00:55:32 -08:00
										 |  |  | static const struct file_operations umad_sm_fops = { | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:50 +00:00
										 |  |  | 	.owner	 = THIS_MODULE, | 
					
						
							|  |  |  | 	.open	 = ib_umad_sm_open, | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	.release = ib_umad_sm_close | 
					
						
							|  |  |  | }; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static struct ib_client umad_client = { | 
					
						
							|  |  |  | 	.name   = "umad", | 
					
						
							|  |  |  | 	.add    = ib_umad_add_one, | 
					
						
							|  |  |  | 	.remove = ib_umad_remove_one | 
					
						
							|  |  |  | }; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2008-02-22 00:13:36 +01:00
										 |  |  | static ssize_t show_ibdev(struct device *dev, struct device_attribute *attr, | 
					
						
							|  |  |  | 			  char *buf) | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | { | 
					
						
							| 
									
										
										
										
											2008-02-22 00:13:36 +01:00
										 |  |  | 	struct ib_umad_port *port = dev_get_drvdata(dev); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 	if (!port) | 
					
						
							|  |  |  | 		return -ENODEV; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	return sprintf(buf, "%s\n", port->ib_dev->name); | 
					
						
							|  |  |  | } | 
					
						
							| 
									
										
										
										
											2008-02-22 00:13:36 +01:00
										 |  |  | static DEVICE_ATTR(ibdev, S_IRUGO, show_ibdev, NULL); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2008-02-22 00:13:36 +01:00
										 |  |  | static ssize_t show_port(struct device *dev, struct device_attribute *attr, | 
					
						
							|  |  |  | 			 char *buf) | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | { | 
					
						
							| 
									
										
										
										
											2008-02-22 00:13:36 +01:00
										 |  |  | 	struct ib_umad_port *port = dev_get_drvdata(dev); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 	if (!port) | 
					
						
							|  |  |  | 		return -ENODEV; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	return sprintf(buf, "%d\n", port->port_num); | 
					
						
							|  |  |  | } | 
					
						
							| 
									
										
										
										
											2008-02-22 00:13:36 +01:00
										 |  |  | static DEVICE_ATTR(port, S_IRUGO, show_port, NULL); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2010-01-05 12:48:09 +01:00
										 |  |  | static CLASS_ATTR_STRING(abi_version, S_IRUGO, | 
					
						
							|  |  |  | 			 __stringify(IB_USER_MAD_ABI_VERSION)); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:45 +00:00
										 |  |  | static dev_t overflow_maj; | 
					
						
							|  |  |  | static DECLARE_BITMAP(overflow_map, IB_UMAD_MAX_PORTS); | 
					
						
							|  |  |  | static int find_overflow_devnum(void) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  | 	int ret; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	if (!overflow_maj) { | 
					
						
							|  |  |  | 		ret = alloc_chrdev_region(&overflow_maj, 0, IB_UMAD_MAX_PORTS * 2, | 
					
						
							|  |  |  | 					  "infiniband_mad"); | 
					
						
							|  |  |  | 		if (ret) { | 
					
						
							|  |  |  | 			printk(KERN_ERR "user_mad: couldn't register dynamic device number\n"); | 
					
						
							|  |  |  | 			return ret; | 
					
						
							|  |  |  | 		} | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	ret = find_first_zero_bit(overflow_map, IB_UMAD_MAX_PORTS); | 
					
						
							|  |  |  | 	if (ret >= IB_UMAD_MAX_PORTS) | 
					
						
							|  |  |  | 		return -1; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	return ret; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | static int ib_umad_init_port(struct ib_device *device, int port_num, | 
					
						
							|  |  |  | 			     struct ib_umad_port *port) | 
					
						
							|  |  |  | { | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:35 +00:00
										 |  |  | 	int devnum; | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:40 +00:00
										 |  |  | 	dev_t base; | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:35 +00:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 	spin_lock(&port_lock); | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:35 +00:00
										 |  |  | 	devnum = find_first_zero_bit(dev_map, IB_UMAD_MAX_PORTS); | 
					
						
							|  |  |  | 	if (devnum >= IB_UMAD_MAX_PORTS) { | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 		spin_unlock(&port_lock); | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:45 +00:00
										 |  |  | 		devnum = find_overflow_devnum(); | 
					
						
							|  |  |  | 		if (devnum < 0) | 
					
						
							|  |  |  | 			return -1; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 		spin_lock(&port_lock); | 
					
						
							|  |  |  | 		port->dev_num = devnum + IB_UMAD_MAX_PORTS; | 
					
						
							|  |  |  | 		base = devnum + overflow_maj; | 
					
						
							|  |  |  | 		set_bit(devnum, overflow_map); | 
					
						
							|  |  |  | 	} else { | 
					
						
							|  |  |  | 		port->dev_num = devnum; | 
					
						
							|  |  |  | 		base = devnum + base_dev; | 
					
						
							|  |  |  | 		set_bit(devnum, dev_map); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	} | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 	spin_unlock(&port_lock); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							|  |  |  | 	port->ib_dev   = device; | 
					
						
							|  |  |  | 	port->port_num = port_num; | 
					
						
							|  |  |  | 	init_MUTEX(&port->sm_sem); | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	mutex_init(&port->file_mutex); | 
					
						
							| 
									
										
										
										
											2005-11-03 12:01:18 -08:00
										 |  |  | 	INIT_LIST_HEAD(&port->file_list); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:25 +00:00
										 |  |  | 	cdev_init(&port->cdev, &umad_fops); | 
					
						
							|  |  |  | 	port->cdev.owner = THIS_MODULE; | 
					
						
							|  |  |  | 	kobject_set_name(&port->cdev.kobj, "umad%d", port->dev_num); | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:40 +00:00
										 |  |  | 	if (cdev_add(&port->cdev, base, 1)) | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 		goto err_cdev; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2008-07-21 20:03:34 -07:00
										 |  |  | 	port->dev = device_create(umad_class, device->dma_device, | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:25 +00:00
										 |  |  | 				  port->cdev.dev, port, | 
					
						
							| 
									
										
										
										
											2008-07-21 20:03:34 -07:00
										 |  |  | 				  "umad%d", port->dev_num); | 
					
						
							| 
									
										
										
										
											2008-02-22 00:13:36 +01:00
										 |  |  | 	if (IS_ERR(port->dev)) | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 		goto err_cdev; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2008-02-22 00:13:36 +01:00
										 |  |  | 	if (device_create_file(port->dev, &dev_attr_ibdev)) | 
					
						
							|  |  |  | 		goto err_dev; | 
					
						
							|  |  |  | 	if (device_create_file(port->dev, &dev_attr_port)) | 
					
						
							|  |  |  | 		goto err_dev; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:40 +00:00
										 |  |  | 	base += IB_UMAD_MAX_PORTS; | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:25 +00:00
										 |  |  | 	cdev_init(&port->sm_cdev, &umad_sm_fops); | 
					
						
							|  |  |  | 	port->sm_cdev.owner = THIS_MODULE; | 
					
						
							|  |  |  | 	kobject_set_name(&port->sm_cdev.kobj, "issm%d", port->dev_num); | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:40 +00:00
										 |  |  | 	if (cdev_add(&port->sm_cdev, base, 1)) | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 		goto err_sm_cdev; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2008-07-21 20:03:34 -07:00
										 |  |  | 	port->sm_dev = device_create(umad_class, device->dma_device, | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:25 +00:00
										 |  |  | 				     port->sm_cdev.dev, port, | 
					
						
							| 
									
										
										
										
											2008-07-21 20:03:34 -07:00
										 |  |  | 				     "issm%d", port->dev_num); | 
					
						
							| 
									
										
										
										
											2008-02-22 00:13:36 +01:00
										 |  |  | 	if (IS_ERR(port->sm_dev)) | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 		goto err_sm_cdev; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2008-02-22 00:13:36 +01:00
										 |  |  | 	if (device_create_file(port->sm_dev, &dev_attr_ibdev)) | 
					
						
							|  |  |  | 		goto err_sm_dev; | 
					
						
							|  |  |  | 	if (device_create_file(port->sm_dev, &dev_attr_port)) | 
					
						
							|  |  |  | 		goto err_sm_dev; | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							|  |  |  | 	return 0; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2008-02-22 00:13:36 +01:00
										 |  |  | err_sm_dev: | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:25 +00:00
										 |  |  | 	device_destroy(umad_class, port->sm_cdev.dev); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							|  |  |  | err_sm_cdev: | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:25 +00:00
										 |  |  | 	cdev_del(&port->sm_cdev); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2008-02-22 00:13:36 +01:00
										 |  |  | err_dev: | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:25 +00:00
										 |  |  | 	device_destroy(umad_class, port->cdev.dev); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							|  |  |  | err_cdev: | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:25 +00:00
										 |  |  | 	cdev_del(&port->cdev); | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:45 +00:00
										 |  |  | 	if (port->dev_num < IB_UMAD_MAX_PORTS) | 
					
						
							|  |  |  | 		clear_bit(devnum, dev_map); | 
					
						
							|  |  |  | 	else | 
					
						
							|  |  |  | 		clear_bit(devnum, overflow_map); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							|  |  |  | 	return -1; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | static void ib_umad_kill_port(struct ib_umad_port *port) | 
					
						
							|  |  |  | { | 
					
						
							| 
									
										
										
										
											2005-11-03 12:01:18 -08:00
										 |  |  | 	struct ib_umad_file *file; | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	int already_dead; | 
					
						
							| 
									
										
										
										
											2005-11-03 12:01:18 -08:00
										 |  |  | 	int id; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2008-02-22 00:13:36 +01:00
										 |  |  | 	dev_set_drvdata(port->dev,    NULL); | 
					
						
							|  |  |  | 	dev_set_drvdata(port->sm_dev, NULL); | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:25 +00:00
										 |  |  | 	device_destroy(umad_class, port->cdev.dev); | 
					
						
							|  |  |  | 	device_destroy(umad_class, port->sm_cdev.dev); | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:25 +00:00
										 |  |  | 	cdev_del(&port->cdev); | 
					
						
							|  |  |  | 	cdev_del(&port->sm_cdev); | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	mutex_lock(&port->file_mutex); | 
					
						
							| 
									
										
										
										
											2005-11-03 12:01:18 -08:00
										 |  |  | 
 | 
					
						
							|  |  |  | 	port->ib_dev = NULL; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	list_for_each_entry(file, &port->file_list, port_list) { | 
					
						
							|  |  |  | 		mutex_lock(&file->mutex); | 
					
						
							|  |  |  | 		already_dead = file->agents_dead; | 
					
						
							| 
									
										
										
										
											2005-11-10 10:18:23 -08:00
										 |  |  | 		file->agents_dead = 1; | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 		mutex_unlock(&file->mutex); | 
					
						
							| 
									
										
										
										
											2005-11-10 10:18:23 -08:00
										 |  |  | 
 | 
					
						
							|  |  |  | 		for (id = 0; id < IB_UMAD_MAX_AGENTS; ++id) | 
					
						
							|  |  |  | 			if (file->agent[id]) | 
					
						
							|  |  |  | 				ib_unregister_mad_agent(file->agent[id]); | 
					
						
							|  |  |  | 	} | 
					
						
							| 
									
										
										
										
											2005-11-03 12:01:18 -08:00
										 |  |  | 
 | 
					
						
							| 
									
										
											  
											
												IB/umad: Simplify and fix locking
In addition to being overly complex, the locking in user_mad.c is
broken: there were multiple reports of deadlocks and lockdep warnings.
In particular it seems that a single thread may end up trying to take
the same rwsem for reading more than once, which is explicitly
forbidden in the comments in <linux/rwsem.h>.
To solve this, we change the locking to use plain mutexes instead of
rwsems.  There is one mutex per open file, which protects the contents
of the struct ib_umad_file, including the array of agents and list of
queued packets; and there is one mutex per struct ib_umad_port, which
protects the contents, including the list of open files.  We never
hold the file mutex across calls to functions like ib_unregister_mad_agent(),
which can call back into other ib_umad code to queue a packet, and we
always hold the port mutex as long as we need to make sure that a
device is not hot-unplugged from under us.
This even makes things nicer for users of the -rt patch, since we
remove calls to downgrade_write() (which is not implemented in -rt).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
											
										 
											2008-01-25 14:15:42 -08:00
										 |  |  | 	mutex_unlock(&port->file_mutex); | 
					
						
							| 
									
										
										
										
											2005-11-03 12:01:18 -08:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:45 +00:00
										 |  |  | 	if (port->dev_num < IB_UMAD_MAX_PORTS) | 
					
						
							|  |  |  | 		clear_bit(port->dev_num, dev_map); | 
					
						
							|  |  |  | 	else | 
					
						
							|  |  |  | 		clear_bit(port->dev_num - IB_UMAD_MAX_PORTS, overflow_map); | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | static void ib_umad_add_one(struct ib_device *device) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  | 	struct ib_umad_device *umad_dev; | 
					
						
							|  |  |  | 	int s, e, i; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2006-08-03 16:02:42 -05:00
										 |  |  | 	if (rdma_node_get_transport(device->node_type) != RDMA_TRANSPORT_IB) | 
					
						
							|  |  |  | 		return; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	if (device->node_type == RDMA_NODE_IB_SWITCH) | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 		s = e = 0; | 
					
						
							|  |  |  | 	else { | 
					
						
							|  |  |  | 		s = 1; | 
					
						
							|  |  |  | 		e = device->phys_port_cnt; | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-10-27 20:48:11 -07:00
										 |  |  | 	umad_dev = kzalloc(sizeof *umad_dev + | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 			   (e - s + 1) * sizeof (struct ib_umad_port), | 
					
						
							|  |  |  | 			   GFP_KERNEL); | 
					
						
							|  |  |  | 	if (!umad_dev) | 
					
						
							|  |  |  | 		return; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	kref_init(&umad_dev->ref); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	umad_dev->start_port = s; | 
					
						
							|  |  |  | 	umad_dev->end_port   = e; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	for (i = s; i <= e; ++i) { | 
					
						
							|  |  |  | 		umad_dev->port[i - s].umad_dev = umad_dev; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 		if (ib_umad_init_port(device, i, &umad_dev->port[i - s])) | 
					
						
							|  |  |  | 			goto err; | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	ib_set_client_data(device, &umad_client, umad_dev); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	return; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | err: | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 	while (--i >= s) | 
					
						
							| 
									
										
										
										
											2005-11-06 15:47:02 -08:00
										 |  |  | 		ib_umad_kill_port(&umad_dev->port[i - s]); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							|  |  |  | 	kref_put(&umad_dev->ref, ib_umad_release_dev); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static void ib_umad_remove_one(struct ib_device *device) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  | 	struct ib_umad_device *umad_dev = ib_get_client_data(device, &umad_client); | 
					
						
							|  |  |  | 	int i; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	if (!umad_dev) | 
					
						
							|  |  |  | 		return; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 	for (i = 0; i <= umad_dev->end_port - umad_dev->start_port; ++i) | 
					
						
							|  |  |  | 		ib_umad_kill_port(&umad_dev->port[i]); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							|  |  |  | 	kref_put(&umad_dev->ref, ib_umad_release_dev); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static int __init ib_umad_init(void) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  | 	int ret; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	ret = register_chrdev_region(base_dev, IB_UMAD_MAX_PORTS * 2, | 
					
						
							|  |  |  | 				     "infiniband_mad"); | 
					
						
							|  |  |  | 	if (ret) { | 
					
						
							|  |  |  | 		printk(KERN_ERR "user_mad: couldn't register device number\n"); | 
					
						
							|  |  |  | 		goto out; | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 	umad_class = class_create(THIS_MODULE, "infiniband_mad"); | 
					
						
							|  |  |  | 	if (IS_ERR(umad_class)) { | 
					
						
							|  |  |  | 		ret = PTR_ERR(umad_class); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 		printk(KERN_ERR "user_mad: couldn't create class infiniband_mad\n"); | 
					
						
							|  |  |  | 		goto out_chrdev; | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2010-01-05 12:48:09 +01:00
										 |  |  | 	ret = class_create_file(umad_class, &class_attr_abi_version.attr); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	if (ret) { | 
					
						
							|  |  |  | 		printk(KERN_ERR "user_mad: couldn't create abi_version attribute\n"); | 
					
						
							|  |  |  | 		goto out_class; | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	ret = ib_register_client(&umad_client); | 
					
						
							|  |  |  | 	if (ret) { | 
					
						
							|  |  |  | 		printk(KERN_ERR "user_mad: couldn't register ib_umad client\n"); | 
					
						
							|  |  |  | 		goto out_class; | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	return 0; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | out_class: | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 	class_destroy(umad_class); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 
 | 
					
						
							|  |  |  | out_chrdev: | 
					
						
							|  |  |  | 	unregister_chrdev_region(base_dev, IB_UMAD_MAX_PORTS * 2); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | out: | 
					
						
							|  |  |  | 	return ret; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static void __exit ib_umad_cleanup(void) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  | 	ib_unregister_client(&umad_client); | 
					
						
							| 
									
										
										
										
											2005-10-28 15:37:23 -07:00
										 |  |  | 	class_destroy(umad_class); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | 	unregister_chrdev_region(base_dev, IB_UMAD_MAX_PORTS * 2); | 
					
						
							| 
									
										
										
										
											2010-02-02 19:08:45 +00:00
										 |  |  | 	if (overflow_maj) | 
					
						
							|  |  |  | 		unregister_chrdev_region(overflow_maj, IB_UMAD_MAX_PORTS * 2); | 
					
						
							| 
									
										
										
										
											2005-04-16 15:20:36 -07:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | module_init(ib_umad_init); | 
					
						
							|  |  |  | module_exit(ib_umad_cleanup); |