| 
									
										
										
										
											2007-10-26 02:49:09 -07:00
										 |  |  | 
 | 
					
						
							|  |  |  | The "enviromental" rules for authors of any new tc actions are: | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 1) If you stealeth or borroweth any packet thou shalt be branching | 
					
						
							|  |  |  | from the righteous path and thou shalt cloneth. | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2008-07-25 19:45:33 -07:00
										 |  |  | For example if your action queues a packet to be processed later, | 
					
						
							|  |  |  | or intentionally branches by redirecting a packet, then you need to | 
					
						
							| 
									
										
										
										
											2007-10-26 02:49:09 -07:00
										 |  |  | clone the packet. | 
					
						
							| 
									
										
										
										
											2008-07-25 19:45:33 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2007-10-26 02:49:09 -07:00
										 |  |  | There are certain fields in the skb tc_verd that need to be reset so we | 
					
						
							| 
									
										
										
										
											2008-07-25 19:45:33 -07:00
										 |  |  | avoid loops, etc.  A few are generic enough that skb_act_clone() | 
					
						
							|  |  |  | resets them for you, so invoke skb_act_clone() rather than skb_clone(). | 
					
						
							| 
									
										
										
										
											2007-10-26 02:49:09 -07:00
										 |  |  | 
 | 
					
						
							|  |  |  | 2) If you munge any packet thou shalt call pskb_expand_head in the case | 
					
						
							|  |  |  | someone else is referencing the skb. After that you "own" the skb. | 
					
						
							|  |  |  | You must also tell us if it is ok to munge the packet (TC_OK2MUNGE), | 
					
						
							|  |  |  | this way any action downstream can stomp on the packet. | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2008-07-25 19:45:33 -07:00
										 |  |  | 3) Dropping packets you don't own is a no-no. You simply return | 
					
						
							| 
									
										
										
										
											2007-10-26 02:49:09 -07:00
										 |  |  | TC_ACT_SHOT to the caller and they will drop it. | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | The "enviromental" rules for callers of actions (qdiscs etc) are: | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2008-07-25 19:45:33 -07:00
										 |  |  | *) Thou art responsible for freeing anything returned as being | 
					
						
							| 
									
										
										
										
											2007-10-26 02:49:09 -07:00
										 |  |  | TC_ACT_SHOT/STOLEN/QUEUED. If none of TC_ACT_SHOT/STOLEN/QUEUED is | 
					
						
							| 
									
										
										
										
											2008-07-25 19:45:33 -07:00
										 |  |  | returned, then all is great and you don't need to do anything. | 
					
						
							| 
									
										
										
										
											2007-10-26 02:49:09 -07:00
										 |  |  | 
 | 
					
						
							|  |  |  | Post on netdev if something is unclear. | 
					
						
							|  |  |  | 
 |