| 
									
										
										
										
											2005-09-11 19:15:07 -07:00
										 |  |  | /*
 | 
					
						
							|  |  |  |  * 	cn_test.c | 
					
						
							|  |  |  |  *  | 
					
						
							|  |  |  |  * 2004-2005 Copyright (c) Evgeniy Polyakov <johnpol@2ka.mipt.ru> | 
					
						
							|  |  |  |  * All rights reserved. | 
					
						
							|  |  |  |  *  | 
					
						
							|  |  |  |  * This program is free software; you can redistribute it and/or modify | 
					
						
							|  |  |  |  * it under the terms of the GNU General Public License as published by | 
					
						
							|  |  |  |  * the Free Software Foundation; either version 2 of the License, or | 
					
						
							|  |  |  |  * (at your option) any later version. | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * This program is distributed in the hope that it will be useful, | 
					
						
							|  |  |  |  * but WITHOUT ANY WARRANTY; without even the implied warranty of | 
					
						
							|  |  |  |  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the | 
					
						
							|  |  |  |  * GNU General Public License for more details. | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * You should have received a copy of the GNU General Public License | 
					
						
							|  |  |  |  * along with this program; if not, write to the Free Software | 
					
						
							|  |  |  |  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA | 
					
						
							|  |  |  |  */ | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | #include <linux/kernel.h>
 | 
					
						
							|  |  |  | #include <linux/module.h>
 | 
					
						
							|  |  |  | #include <linux/moduleparam.h>
 | 
					
						
							|  |  |  | #include <linux/skbuff.h>
 | 
					
						
							|  |  |  | #include <linux/timer.h>
 | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-11-08 09:38:56 -08:00
										 |  |  | #include <linux/connector.h>
 | 
					
						
							| 
									
										
										
										
											2005-09-11 19:15:07 -07:00
										 |  |  | 
 | 
					
						
							|  |  |  | static struct cb_id cn_test_id = { 0x123, 0x456 }; | 
					
						
							|  |  |  | static char cn_test_name[] = "cn_test"; | 
					
						
							|  |  |  | static struct sock *nls; | 
					
						
							|  |  |  | static struct timer_list cn_test_timer; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | void cn_test_callback(void *data) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  | 	struct cn_msg *msg = (struct cn_msg *)data; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	printk("%s: %lu: idx=%x, val=%x, seq=%u, ack=%u, len=%d: %s.\n", | 
					
						
							|  |  |  | 	       __func__, jiffies, msg->id.idx, msg->id.val, | 
					
						
							|  |  |  | 	       msg->seq, msg->ack, msg->len, (char *)msg->data); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static int cn_test_want_notify(void) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  | 	struct cn_ctl_msg *ctl; | 
					
						
							|  |  |  | 	struct cn_notify_req *req; | 
					
						
							|  |  |  | 	struct cn_msg *msg = NULL; | 
					
						
							|  |  |  | 	int size, size0; | 
					
						
							|  |  |  | 	struct sk_buff *skb; | 
					
						
							|  |  |  | 	struct nlmsghdr *nlh; | 
					
						
							|  |  |  | 	u32 group = 1; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	size0 = sizeof(*msg) + sizeof(*ctl) + 3 * sizeof(*req); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	size = NLMSG_SPACE(size0); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	skb = alloc_skb(size, GFP_ATOMIC); | 
					
						
							|  |  |  | 	if (!skb) { | 
					
						
							|  |  |  | 		printk(KERN_ERR "Failed to allocate new skb with size=%u.\n", | 
					
						
							|  |  |  | 		       size); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 		return -ENOMEM; | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	nlh = NLMSG_PUT(skb, 0, 0x123, NLMSG_DONE, size - sizeof(*nlh)); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	msg = (struct cn_msg *)NLMSG_DATA(nlh); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	memset(msg, 0, size0); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	msg->id.idx = -1; | 
					
						
							|  |  |  | 	msg->id.val = -1; | 
					
						
							|  |  |  | 	msg->seq = 0x123; | 
					
						
							|  |  |  | 	msg->ack = 0x345; | 
					
						
							|  |  |  | 	msg->len = size0 - sizeof(*msg); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	ctl = (struct cn_ctl_msg *)(msg + 1); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	ctl->idx_notify_num = 1; | 
					
						
							|  |  |  | 	ctl->val_notify_num = 2; | 
					
						
							|  |  |  | 	ctl->group = group; | 
					
						
							|  |  |  | 	ctl->len = msg->len - sizeof(*ctl); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	req = (struct cn_notify_req *)(ctl + 1); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	/*
 | 
					
						
							|  |  |  | 	 * Idx. | 
					
						
							|  |  |  | 	 */ | 
					
						
							|  |  |  | 	req->first = cn_test_id.idx; | 
					
						
							|  |  |  | 	req->range = 10; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	/*
 | 
					
						
							|  |  |  | 	 * Val 0. | 
					
						
							|  |  |  | 	 */ | 
					
						
							|  |  |  | 	req++; | 
					
						
							|  |  |  | 	req->first = cn_test_id.val; | 
					
						
							|  |  |  | 	req->range = 10; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	/*
 | 
					
						
							|  |  |  | 	 * Val 1. | 
					
						
							|  |  |  | 	 */ | 
					
						
							|  |  |  | 	req++; | 
					
						
							|  |  |  | 	req->first = cn_test_id.val + 20; | 
					
						
							|  |  |  | 	req->range = 10; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2005-11-08 09:38:56 -08:00
										 |  |  | 	NETLINK_CB(skb).dst_group = ctl->group; | 
					
						
							| 
									
										
										
										
											2005-09-11 19:15:07 -07:00
										 |  |  | 	//netlink_broadcast(nls, skb, 0, ctl->group, GFP_ATOMIC);
 | 
					
						
							|  |  |  | 	netlink_unicast(nls, skb, 0, 0); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	printk(KERN_INFO "Request was sent. Group=0x%x.\n", ctl->group); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	return 0; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | nlmsg_failure: | 
					
						
							|  |  |  | 	printk(KERN_ERR "Failed to send %u.%u\n", msg->seq, msg->ack); | 
					
						
							|  |  |  | 	kfree_skb(skb); | 
					
						
							|  |  |  | 	return -EINVAL; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static u32 cn_test_timer_counter; | 
					
						
							|  |  |  | static void cn_test_timer_func(unsigned long __data) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  | 	struct cn_msg *m; | 
					
						
							|  |  |  | 	char data[32]; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												some kmalloc/memset ->kzalloc (tree wide)
Transform some calls to kmalloc/memset to a single kzalloc (or kcalloc).
Here is a short excerpt of the semantic patch performing
this transformation:
@@
type T2;
expression x;
identifier f,fld;
expression E;
expression E1,E2;
expression e1,e2,e3,y;
statement S;
@@
 x =
- kmalloc
+ kzalloc
  (E1,E2)
  ...  when != \(x->fld=E;\|y=f(...,x,...);\|f(...,x,...);\|x=E;\|while(...) S\|for(e1;e2;e3) S\)
- memset((T2)x,0,E1);
@@
expression E1,E2,E3;
@@
- kzalloc(E1 * E2,E3)
+ kcalloc(E1,E2,E3)
[akpm@linux-foundation.org: get kcalloc args the right way around]
Signed-off-by: Yoann Padioleau <padator@wanadoo.fr>
Cc: Richard Henderson <rth@twiddle.net>
Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Acked-by: Russell King <rmk@arm.linux.org.uk>
Cc: Bryan Wu <bryan.wu@analog.com>
Acked-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Dave Airlie <airlied@linux.ie>
Acked-by: Roland Dreier <rolandd@cisco.com>
Cc: Jiri Kosina <jkosina@suse.cz>
Acked-by: Dmitry Torokhov <dtor@mail.ru>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Acked-by: Pierre Ossman <drzeus-list@drzeus.cx>
Cc: Jeff Garzik <jeff@garzik.org>
Cc: "David S. Miller" <davem@davemloft.net>
Acked-by: Greg KH <greg@kroah.com>
Cc: James Bottomley <James.Bottomley@steeleye.com>
Cc: "Antonino A. Daplas" <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
											
										 
											2007-07-19 01:49:03 -07:00
										 |  |  | 	m = kzalloc(sizeof(*m) + sizeof(data), GFP_ATOMIC); | 
					
						
							| 
									
										
										
										
											2005-09-11 19:15:07 -07:00
										 |  |  | 	if (m) { | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 		memcpy(&m->id, &cn_test_id, sizeof(m->id)); | 
					
						
							|  |  |  | 		m->seq = cn_test_timer_counter; | 
					
						
							|  |  |  | 		m->len = sizeof(data); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 		m->len = | 
					
						
							|  |  |  | 		    scnprintf(data, sizeof(data), "counter = %u", | 
					
						
							|  |  |  | 			      cn_test_timer_counter) + 1; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 		memcpy(m + 1, data, m->len); | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2009-02-12 16:47:01 -08:00
										 |  |  | 		cn_netlink_send(m, 0, GFP_ATOMIC); | 
					
						
							| 
									
										
										
										
											2005-09-11 19:15:07 -07:00
										 |  |  | 		kfree(m); | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	cn_test_timer_counter++; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	mod_timer(&cn_test_timer, jiffies + HZ); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static int cn_test_init(void) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  | 	int err; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	err = cn_add_callback(&cn_test_id, cn_test_name, cn_test_callback); | 
					
						
							|  |  |  | 	if (err) | 
					
						
							|  |  |  | 		goto err_out; | 
					
						
							|  |  |  | 	cn_test_id.val++; | 
					
						
							|  |  |  | 	err = cn_add_callback(&cn_test_id, cn_test_name, cn_test_callback); | 
					
						
							|  |  |  | 	if (err) { | 
					
						
							|  |  |  | 		cn_del_callback(&cn_test_id); | 
					
						
							|  |  |  | 		goto err_out; | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2009-02-12 16:47:01 -08:00
										 |  |  | 	setup_timer(&cn_test_timer, cn_test_timer_func, 0); | 
					
						
							| 
									
										
										
										
											2005-09-11 19:15:07 -07:00
										 |  |  | 	cn_test_timer.expires = jiffies + HZ; | 
					
						
							|  |  |  | 	add_timer(&cn_test_timer); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	return 0; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |       err_out: | 
					
						
							|  |  |  | 	if (nls && nls->sk_socket) | 
					
						
							|  |  |  | 		sock_release(nls->sk_socket); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	return err; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static void cn_test_fini(void) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  | 	del_timer_sync(&cn_test_timer); | 
					
						
							|  |  |  | 	cn_del_callback(&cn_test_id); | 
					
						
							|  |  |  | 	cn_test_id.val--; | 
					
						
							|  |  |  | 	cn_del_callback(&cn_test_id); | 
					
						
							|  |  |  | 	if (nls && nls->sk_socket) | 
					
						
							|  |  |  | 		sock_release(nls->sk_socket); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | module_init(cn_test_init); | 
					
						
							|  |  |  | module_exit(cn_test_fini); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | MODULE_LICENSE("GPL"); | 
					
						
							|  |  |  | MODULE_AUTHOR("Evgeniy Polyakov <johnpol@2ka.mipt.ru>"); | 
					
						
							|  |  |  | MODULE_DESCRIPTION("Connector's test module"); |